unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan <monnier@iro.umontreal.ca>
To: Florian Beck <fb@miszellen.de>
Cc: 16959@debbugs.gnu.org
Subject: bug#16959: bug#16981: 24.3.50; electric-pair-delete-adjacent-pairs broken in c-mode, python-mode, maybe-others
Date: Fri, 21 Mar 2014 17:47:55 -0400	[thread overview]
Message-ID: <jwveh1xwt5z.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <532A373C.2050502@miszellen.de> (Florian Beck's message of "Thu,  20 Mar 2014 01:33:00 +0100")

>  - also link "in order to trace the calls to the process filter of a
> process" to "Filter Functions"

I find Texinfo links to be a bit heavy, so I prefer not to put too many
of them, so the reader can concentrate on the subject.  Process filters
are not really relevant.

>  - in the last paragraph ":above" should be ":around";

Fixed.

> the formatting "_advice_" is strange

That's how Texinfo renders @emph in Info.

> Core Advising Primitives:
>  - Should the WHERE specifications have their own node or section?

Sizewise, I fully agree, so I moved it to its own node/section.  I'm not
completely happy with the result, but I think it's better.

> In any case, I would move the second example (his-tracing-function) to
> the end of the list and explain it a little bit.

I'd rather keep the advice-add in the first node alongside the
add-function example, since as you say in many cases advice-add is what
the reader is really after.

>  - depth: clarify what happens when you have several pieces of ":override"
> or ":around" advice that doesn't call the original function at the depth 0.

I tried to clarify the notion of depth by spelling out what it means
for :after, :before and :override.

> Advising named functions:
>  - "Macros can also be advised": this doesn't work when the macro is used
> in a compiled function.

Of course it works.  The restriction is that the macro needs to be
advised before it is expanded.  I spelled it out now.


        Stefan





  reply	other threads:[~2014-03-21 21:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <mailman.16921.1394480964.10748.bug-gnu-emacs@gnu.org>
2014-03-10 19:47 ` bug#16981: 24.3.50; electric-pair-delete-adjacent-pairs broken in c-mode, python-mode, maybe-others João Távora
2014-03-13 22:04   ` Alan Mackenzie
2014-03-18  1:56     ` bug#16959: " Stefan
2014-03-20  0:33       ` Florian Beck
2014-03-21 21:47         ` Stefan [this message]
2014-03-25 17:38           ` Florian Beck
2014-03-26  0:34             ` Stefan Monnier
2014-04-05 11:58     ` João Távora
2014-04-05 15:45       ` Stefan Monnier
2014-04-06  1:51         ` João Távora
2014-04-06 12:48           ` Stefan Monnier
2014-04-06 15:08             ` João Távora
2014-04-07  0:04             ` João Távora

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwveh1xwt5z.fsf-monnier+emacsbugs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=16959@debbugs.gnu.org \
    --cc=fb@miszellen.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).