From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#19324: 25.0.50; add-function and nil Date: Wed, 10 Dec 2014 14:54:42 -0500 Message-ID: References: <87vbllxw05.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1418241333 32563 80.91.229.3 (10 Dec 2014 19:55:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 10 Dec 2014 19:55:33 +0000 (UTC) Cc: 19324@debbugs.gnu.org To: Leo Liu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 10 20:55:25 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XynM5-000679-AM for geb-bug-gnu-emacs@m.gmane.org; Wed, 10 Dec 2014 20:55:25 +0100 Original-Received: from localhost ([::1]:47691 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XynM0-0008Cs-Hz for geb-bug-gnu-emacs@m.gmane.org; Wed, 10 Dec 2014 14:55:20 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35269) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XynLq-0008CG-9U for bug-gnu-emacs@gnu.org; Wed, 10 Dec 2014 14:55:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XynLi-0000NI-NP for bug-gnu-emacs@gnu.org; Wed, 10 Dec 2014 14:55:10 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:60848) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XynLi-0000Lj-GM for bug-gnu-emacs@gnu.org; Wed, 10 Dec 2014 14:55:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XynLi-0006FG-8S for bug-gnu-emacs@gnu.org; Wed, 10 Dec 2014 14:55:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Dec 2014 19:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19324 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19324-submit@debbugs.gnu.org id=B19324.141824128823981 (code B ref 19324); Wed, 10 Dec 2014 19:55:02 +0000 Original-Received: (at 19324) by debbugs.gnu.org; 10 Dec 2014 19:54:48 +0000 Original-Received: from localhost ([127.0.0.1]:41981 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XynLT-0006Ej-Nt for submit@debbugs.gnu.org; Wed, 10 Dec 2014 14:54:48 -0500 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:33073) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XynLQ-0006EY-B8 for 19324@debbugs.gnu.org; Wed, 10 Dec 2014 14:54:45 -0500 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id sBAJshoK005737; Wed, 10 Dec 2014 14:54:43 -0500 Original-Received: by ceviche.home (Postfix, from userid 20848) id E7C616610C; Wed, 10 Dec 2014 14:54:42 -0500 (EST) In-Reply-To: <87vbllxw05.fsf@gmail.com> (Leo Liu's message of "Tue, 09 Dec 2014 12:55:22 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5151=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5151> : inlines <1621> : streams <1354805> : uri <1838052> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:97160 Archived-At: > 1. Goto a buffer (e.g. text-mode) with eldoc-documentation-function nil > 2. (add-function :after-until (local 'eldoc-documentation-function) #'ignore) > 3. Move around to trigger eldoc error: (void-function nil) > Looks like the orig function is unconditionally called without checking > it's a function object. Indeed. But I don't think advice.el should handle this case. IOW the way I see it there are 2 ways to fix this problem: - Change the default value so it's always a function. - Make sure all the functions you add use either :override or :around and check that the orig is not nil before calling it. Obviously, the first option is much better, which is why I've been changing various foo-function variables so that their default value is not nil. Stefan