From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#30190: 27.0.50; term run in line mode shows user passwords Date: Wed, 18 Jul 2018 11:54:46 -0400 Message-ID: References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> <87wozfkt9t.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> <83606q6xr7.fsf@gnu.org> <873718qpme.fsf@gmail.com> <87in6erte5.fsf@gmail.com> <83efh1s9s3.fsf@gnu.org> <87602drqan.fsf@gmail.com> <8336xgsvt3.fsf@gnu.org> <878t6892pv.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1531929391 9762 195.159.176.226 (18 Jul 2018 15:56:31 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 18 Jul 2018 15:56:31 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 30190@debbugs.gnu.org, Noam Postavsky To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 18 17:56:27 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffooS-0002OW-FA for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 Jul 2018 17:56:24 +0200 Original-Received: from localhost ([::1]:37354 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffoqZ-00008b-Hs for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 Jul 2018 11:58:35 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56476) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffonD-00065y-Qa for bug-gnu-emacs@gnu.org; Wed, 18 Jul 2018 11:55:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ffon9-0005ZB-UV for bug-gnu-emacs@gnu.org; Wed, 18 Jul 2018 11:55:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42092) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ffon9-0005Yb-QV for bug-gnu-emacs@gnu.org; Wed, 18 Jul 2018 11:55:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ffon8-0002HJ-2t for bug-gnu-emacs@gnu.org; Wed, 18 Jul 2018 11:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Jul 2018 15:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30190 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed security Original-Received: via spool by 30190-submit@debbugs.gnu.org id=B30190.15319292918735 (code B ref 30190); Wed, 18 Jul 2018 15:55:02 +0000 Original-Received: (at 30190) by debbugs.gnu.org; 18 Jul 2018 15:54:51 +0000 Original-Received: from localhost ([127.0.0.1]:47110 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffomw-0002Gp-Sq for submit@debbugs.gnu.org; Wed, 18 Jul 2018 11:54:51 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:48325) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffomu-0002Gg-O4 for 30190@debbugs.gnu.org; Wed, 18 Jul 2018 11:54:49 -0400 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w6IFtT8V013114; Wed, 18 Jul 2018 11:55:30 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id B920A66101; Wed, 18 Jul 2018 11:54:46 -0400 (EDT) In-Reply-To: (Tino Calancha's message of "Wed, 18 Jul 2018 23:56:34 +0900 (JST)") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6332=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6332> : inlines <6759> : streams <1792914> : uri <2675562> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:148639 Archived-At: >> More specifically, shouldn't `read-passwd` do that for us (hence if it >> doesn't yet, then the right patch is to add this let-binding to >> `read-passwd`)? > I don't think so. `read-passwd' uses ?. as default. The docstring suggest > us to let-bind `read-hide-char' in case we wish another char. But why does term-mode want to use a different char? What's so different about term-mode? > Alternatively we could use ?. always as default, and change > `term-send-invisble'. I don't understand what change to term-send-invisble you're thinking of. > Personaly, I prefer ?* because my vision is quite poor and ?. looks too > small :-| But your vision is not poor only in term-mode, right? So, what you're really saying here is that you'd like to change read-passwd to use ?* instead of ?., isn't it? If so, I have nothing against it, but it's a separate concern from that of bug#30190 and it should apply to all uses of read-passwd. Stefan