From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#44070: 28.0.50; Minibuffer display "jumps" upon minor edit Date: Sun, 01 Nov 2020 13:59:35 -0500 Message-ID: References: <83a6wip43q.fsf@gnu.org> <83sg9uhjy2.fsf@gnu.org> <835z6qgrwt.fsf@gnu.org> <83mu01f5o8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7759"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 44070@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 01 20:00:31 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kZIac-0001v9-JS for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 Nov 2020 20:00:30 +0100 Original-Received: from localhost ([::1]:36372 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZIaX-0008G1-7Z for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 Nov 2020 14:00:27 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38980) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZIaA-0008Fn-Es for bug-gnu-emacs@gnu.org; Sun, 01 Nov 2020 14:00:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55216) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kZIaA-0007BD-4f for bug-gnu-emacs@gnu.org; Sun, 01 Nov 2020 14:00:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kZIaA-0000tO-2u for bug-gnu-emacs@gnu.org; Sun, 01 Nov 2020 14:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Nov 2020 19:00:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44070 X-GNU-PR-Package: emacs Original-Received: via spool by 44070-submit@debbugs.gnu.org id=B44070.16042571843376 (code B ref 44070); Sun, 01 Nov 2020 19:00:01 +0000 Original-Received: (at 44070) by debbugs.gnu.org; 1 Nov 2020 18:59:44 +0000 Original-Received: from localhost ([127.0.0.1]:38527 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZIZs-0000sM-Bx for submit@debbugs.gnu.org; Sun, 01 Nov 2020 13:59:44 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:58485) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZIZq-0000s8-Mj for 44070@debbugs.gnu.org; Sun, 01 Nov 2020 13:59:43 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 56A7C44138D; Sun, 1 Nov 2020 13:59:37 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 1C2514406DA; Sun, 1 Nov 2020 13:59:36 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1604257176; bh=x0oO5RvnpULkXBvRM1UVQF3xhrbPIxC5v+MQVVkv2yA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=BwKURyoX1Pnki85h/FIMzx72ARBmZcIAp0YhfhpYqnslkxgSULipGTCuNvpBWGOHe SLWURqWy4B5+nWcNuH/eVlPfqkXVabE4JCd47uJJV76N752Xk9OEMecF4ywit52D4F h+J5TGdw+TyIxxMBVqwM38X10QYDDJ/8MnPZe+rjO08jQrFiA9JVPwUgInneJeqObT 4yyzgh3kHZ98yW3PwbidxPUAyWqv3oNzng0DkDVFR2KiLqNAUXMM1v9uZZovHpGBKU JZPFEzslrj2hbB8UcDOFhXgfJyBdsiyQNJOaOi1+PSth7ICMwID0bARjFEqxxx3YbN cR5Ry57y4VBEQ== Original-Received: from alfajor (unknown [157.52.9.240]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E7EF3120340; Sun, 1 Nov 2020 13:59:35 -0500 (EST) In-Reply-To: <83mu01f5o8.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 01 Nov 2020 17:38:47 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192438 Archived-At: >> Also, I'm not sure that's what we want to do: as I argued in my previous >> message, this change is mostly meant to better fit the behavior of >> resize_mini_window, and that behavior applies to all mini-windows, >> regardless if they're used for a minibuffer or something else. > My line of thinking was that, while in minibuffers we usually want to > see the end of the text, that is not necessarily true in echo-area > messages. Yet, that's what `resize_mini_window` does for all mini-windows regardless of it's an echo-area or not. Also, my patch shouldn't affect whether we "see the end of the text", so maybe I just don't understand what you're referring to. >> I suggest we keep the code as is for now, and we'll consider what to do >> *if* someone encounters a regression (which, for all we know, could >> also affect the minibuffer case). > Then let's leave a FIXME comment about this in those two places where > you use MINI_WINDOW_P, okay? I thought the test of `scroll_minibuffer_conservative` played this role. Stefan