From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#53024: 29.0.50; Wishlist: Byte-compile loaddefs.el? Date: Fri, 05 Aug 2022 09:44:24 -0400 Message-ID: References: <87ee5mdvqu.fsf@gnus.org> <874k5wj6qr.fsf@gnus.org> <878ro5v7jb.fsf@gnus.org> <8735edv6qy.fsf@gnus.org> <87tu6stucm.fsf@gnus.org> <87wnbmc3r0.fsf@gnus.org> <871qtuania.fsf@gnus.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4270"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 53024@debbugs.gnu.org, 'Eli Zaretskii' To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 05 15:45:42 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oJxe2-0000z3-Ai for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Aug 2022 15:45:42 +0200 Original-Received: from localhost ([::1]:35632 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oJxe0-0004Ht-1q for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Aug 2022 09:45:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38626) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJxdO-0004Hf-48 for bug-gnu-emacs@gnu.org; Fri, 05 Aug 2022 09:45:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38766) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oJxdN-0005UX-OU for bug-gnu-emacs@gnu.org; Fri, 05 Aug 2022 09:45:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oJxdN-0002Ai-LF for bug-gnu-emacs@gnu.org; Fri, 05 Aug 2022 09:45:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Aug 2022 13:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53024 X-GNU-PR-Package: emacs Original-Received: via spool by 53024-submit@debbugs.gnu.org id=B53024.16597070808306 (code B ref 53024); Fri, 05 Aug 2022 13:45:01 +0000 Original-Received: (at 53024) by debbugs.gnu.org; 5 Aug 2022 13:44:40 +0000 Original-Received: from localhost ([127.0.0.1]:56748 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJxd2-00029u-KN for submit@debbugs.gnu.org; Fri, 05 Aug 2022 09:44:40 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:37688) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJxd0-00029e-F2 for 53024@debbugs.gnu.org; Fri, 05 Aug 2022 09:44:39 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id ED18680394; Fri, 5 Aug 2022 09:44:32 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 48FA880263; Fri, 5 Aug 2022 09:44:27 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1659707067; bh=bXahza2B0fwTbkAmdq+rkaZCmxL5hlZhyBdmZFzFJWk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=YULeoyTm5f3WHWZz3/vV26PSH4C44F2uKI5nxVe/RuyVwfo+Bwcrq0e0NKAv7e1bS x94jZ/tXvjGCIN1bXJeSP/EifkqOwVGzC333LP3qDYKPSNK6dun9taGmdrnUA01wnE ed0zUtD7vleZHO8Ry1W1eubWwOLRpAa6Poecihv/2f3hneiSeZOsyIRZENLk0wdH6u GLwKchPGVjskkkLQD6+DVw61594am0iFOU+wLhvJs7ysVTVBpwxLx+YmG8YiXOujTH mmFiLWFz9nS9cDopfDDHRfmMtgQ64bT15+9k0MXvl99thk85Y7rxbG0gK2+CaG+1tk DUw9bzeR1MyHQ== Original-Received: from milanesa (net-5-89-24-238.cust.vodafonedsl.it [5.89.24.238]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 7C48F12020D; Fri, 5 Aug 2022 09:44:26 -0400 (EDT) In-Reply-To: <871qtuania.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 05 Aug 2022 14:22:21 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:238916 Archived-At: > ;; Functions and variables with doc strings must be output separately, > ;; so make-docfile can recognize them. Most other things can be output > ;; as byte-code. > > (put 'autoload 'byte-hunk-handler 'byte-compile-file-form-autoload) > (defun byte-compile-file-form-autoload (form) The comment is a bit off, indeed, but the code can't really be simplified because the docstrings are still treated specially (to implement `byte-compile-dynamic-docstrings`). IIUC the comment predates `byte-compile-dynamic-docstrings`, which is why they only mention `make-docfile`. I've just updated the comments. Admittedly, I think there are a few simplifications/improvements we could now make in `bytecomp.el` (as mentioned in one comment), but the benefit would be fairly minor, and it requires more significant changes than just removing some unneeded code. Stefan