From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#61350: Eglot over Tramp freezes with large project Date: Wed, 15 Mar 2023 17:55:27 -0400 Message-ID: References: <87y1ootw2t.fsf@gmail.com> <87r0u0u0rl.fsf@gmx.de> <87mt4otyy1.fsf@gmx.de> <87pm9fk6ht.fsf@gmx.de> <87mt4jzf8q.fsf@gmail.com> <87fsabh2z2.fsf@gmx.de> <87edpvxu7w.fsf@gmail.com> <87bkkzgyb8.fsf@gmx.de> <87lek2x09t.fsf@gmail.com> <875yb646d1.fsf@gmx.de> <87fsa7mw9x.fsf@gmx.de> <87fsa7l6o6.fsf@gmx.de> <87a60fl4p7.fsf@gmx.de> <878rfx6bqe.fsf@gmail.com> <874jql6acx.fsf@gmail.com> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12643"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Thomas Koch , Michael Albinus , 61350@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 15 22:56:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pcZ6f-00035I-Ax for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Mar 2023 22:56:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pcZ6J-0006ml-Lf; Wed, 15 Mar 2023 17:56:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pcZ6I-0006md-9u for bug-gnu-emacs@gnu.org; Wed, 15 Mar 2023 17:56:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pcZ6I-000535-0X for bug-gnu-emacs@gnu.org; Wed, 15 Mar 2023 17:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pcZ6H-0003c6-J4 for bug-gnu-emacs@gnu.org; Wed, 15 Mar 2023 17:56:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Mar 2023 21:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61350 X-GNU-PR-Package: emacs Original-Received: via spool by 61350-submit@debbugs.gnu.org id=B61350.167891733813853 (code B ref 61350); Wed, 15 Mar 2023 21:56:01 +0000 Original-Received: (at 61350) by debbugs.gnu.org; 15 Mar 2023 21:55:38 +0000 Original-Received: from localhost ([127.0.0.1]:40676 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pcZ5u-0003bN-Da for submit@debbugs.gnu.org; Wed, 15 Mar 2023 17:55:38 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:6365) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pcZ5s-0003b9-Me for 61350@debbugs.gnu.org; Wed, 15 Mar 2023 17:55:37 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 92DD880814; Wed, 15 Mar 2023 17:55:30 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id B1630808D1; Wed, 15 Mar 2023 17:55:28 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1678917328; bh=VCahlrqLElSNnG+RRVRHY18KkfzF68KgRd1HhqSJSR4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=E7OYiHuSANe+vK/T50rWbqVZzcKZvIWRjcAOjZX+OtXlIRxrO/BpdnaF084BL0XDq bu0Q5BIZ5zIUS00vxtOH1Plp4Eza0iDX56OZH5agk9rZR93yCMfPNGGTTb25jYZpmV MgKLrkKqBMrUNhUrcu272sNH5awy9GVkW0M12kslsA4max7sXebE5DMLMVWkgFl7sx k+oUH19StIkKwpoz7JgaIW47MVo+CfReWYykDyFC+0ps+FueD+hLY46/vrj35Z0Nzi +vlKtlTrCQuHHWCZ0X81xT2WnnnMrfpUFFLlB55/OCPlqkjl5A39+5OeVFmOPzKsPP ClztcikE2DRZA== Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 92D3412325B; Wed, 15 Mar 2023 17:55:28 -0400 (EDT) In-Reply-To: <874jql6acx.fsf@gmail.com> ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Wed, 15 Mar 2023 20:14:06 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257991 Archived-At: Sorry 'bout my previous email. > diff --git a/lisp/net/tramp.el b/lisp/net/tramp.el > index 47173b95bea..885b29f9471 100644 > --- a/lisp/net/tramp.el > +++ b/lisp/net/tramp.el > @@ -5800,6 +5800,11 @@ tramp-accept-process-output > This is needed in order to hide `last-coding-system-used', which is set > for process communication also. > If the user quits via `C-g', it is propagated up to `tramp-file-name-handler'." > + (when-let (((process-get proc 'shared-socket)) > + (v (process-get proc 'vector))) > + (dolist (p (delq proc (process-list))) > + (when (tramp-file-name-equal-p v (process-get p 'vector)) > + (while (accept-process-output p 0 nil t))))) > (with-current-buffer (process-buffer proc) > (let ((inhibit-read-only t) > last-coding-system-used Looks OK to me (tho this `dolist` in the middle of all those `(tramp-accept-process-output .. 0)` busy loops is definitely not the most efficient use of resources :-). Stefan PS: An unrelated comment, is that `shared-socket` and `vector` should be renamed to clarify that these are properties specific to Tramp processes (i.e. use a `tramp-` prefix).