From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#63509: [PATCH] Make copy-tree work with records Date: Mon, 15 May 2023 10:42:24 -0400 Message-ID: References: <87fs7yfdg2.fsf@breatheoutbreathe.in> <83lehp25ug.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10854"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 63509@debbugs.gnu.org, Joseph Turner To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 15 16:44:31 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pyZR8-0002ar-Uh for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 May 2023 16:44:31 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pyZPk-0000Ze-6o; Mon, 15 May 2023 10:43:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pyZPi-0000VO-8w for bug-gnu-emacs@gnu.org; Mon, 15 May 2023 10:43:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pyZPh-0007AD-Tq for bug-gnu-emacs@gnu.org; Mon, 15 May 2023 10:43:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pyZPh-0001W8-OD for bug-gnu-emacs@gnu.org; Mon, 15 May 2023 10:43:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 May 2023 14:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63509 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63509-submit@debbugs.gnu.org id=B63509.16841617705813 (code B ref 63509); Mon, 15 May 2023 14:43:01 +0000 Original-Received: (at 63509) by debbugs.gnu.org; 15 May 2023 14:42:50 +0000 Original-Received: from localhost ([127.0.0.1]:44127 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pyZPW-0001Vh-3d for submit@debbugs.gnu.org; Mon, 15 May 2023 10:42:50 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:10636) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pyZPU-0001VR-HQ for 63509@debbugs.gnu.org; Mon, 15 May 2023 10:42:49 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 362544434A8; Mon, 15 May 2023 10:42:43 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id E0544443425; Mon, 15 May 2023 10:42:41 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1684161761; bh=QUxJ9wadTrO/vQiwFcCeTAkXevtuiFGrrU0atPvxAs4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=JJpOA8dmGezlS3KZ9U6QqGKWCnbmaX1hg4RU7qLfpovELgKdUqpAKtvDXR8Q/IHZh VLnk/fnnSt4v426rvMVpY8fscjJ+oVRNBm5ArtrszX2PM21t5ZhIoKx50+RqF/NnTn Grkyr15o7U55VklVF09IzYvrNZjFh/E3EFr69rvkDLP9n0twFwqEoDrfiKNLY6+wIN gOZQqXYLkTr/YxGRz0I+Oaq7C2pzokolii1pTTvoLUlQRgkeDu+54So/jb79LkfKbC 5yZ5Qou7tt2xHNtTWhBllOTx4pYClAKMTmfOc9o6r3fBQA2H1q+csmLF+25ydBCouk zkP88OEiarXzg== Original-Received: from pastel (unknown [45.72.217.176]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 623EE1202A2; Mon, 15 May 2023 10:42:41 -0400 (EDT) In-Reply-To: <83lehp25ug.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 15 May 2023 14:26:31 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261744 Archived-At: >> Please tell me if I misunderstand the intended behavior of copy-tree. > Adding Stefan in case he has comments. No specific comment, no. I don't hold `copy-tree` in my heart (it rarely copies exactly what you need, similar problem as for `flatten-tree`), so as general rule I'd recommend against its use, but it's occasionally handy as a quick&dirty "deep copy" function, and extending it to records seem like an obvious fix (it used to do that back when `cl-defstruct` used vectors). Stefan