From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#45029: 27.1.50; Regression: Yanking into externally modified file with delete-selection-mode Date: Thu, 14 Sep 2023 09:44:00 -0400 Message-ID: References: <581f7e67-db12-ba3a-2354-de8061789861@matholka.se> <87360lnabu.fsf@gnus.org> <83a6uscwv2.fsf@gnu.org> <87eek4gl3p.fsf@mail.linkov.net> <86zg1puupr.fsf@mail.linkov.net> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12939"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 45029@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 14 15:45:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qgmel-0003Ci-CC for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 14 Sep 2023 15:45:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qgmeR-0005wX-7Q; Thu, 14 Sep 2023 09:44:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qgmeP-0005vD-Bu for bug-gnu-emacs@gnu.org; Thu, 14 Sep 2023 09:44:57 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qgmeP-0006T1-30 for bug-gnu-emacs@gnu.org; Thu, 14 Sep 2023 09:44:57 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qgmeU-00066H-Hc for bug-gnu-emacs@gnu.org; Thu, 14 Sep 2023 09:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Sep 2023 13:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45029 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed confirmed Original-Received: via spool by 45029-submit@debbugs.gnu.org id=B45029.169469906223386 (code B ref 45029); Thu, 14 Sep 2023 13:45:02 +0000 Original-Received: (at 45029) by debbugs.gnu.org; 14 Sep 2023 13:44:22 +0000 Original-Received: from localhost ([127.0.0.1]:37998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qgmdq-000658-AZ for submit@debbugs.gnu.org; Thu, 14 Sep 2023 09:44:22 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:22665) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qgmdi-00064q-Jf for 45029@debbugs.gnu.org; Thu, 14 Sep 2023 09:44:21 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id CDE6444095C; Thu, 14 Sep 2023 09:44:02 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1694699041; bh=/Njo0ztOBRMH4p+10u9fR/sfEEtaVPKXw4ctgJCXW5I=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=awR8k/I3IIX5xK4LUHOiMa2JXwP1DD9csO1DugCw9QfNYGsF5ygefHEtWYaFB33yb 4HxrfMxHwZivbXcF/ESr+heykIx+WijLE4TlKFcoWKpjrEP3eOIfG8iPw7nF5o9ySY onG8OqZI8hG6Sks9ZKLrKKn70FEhNM++3QErA4pNVaB6wfdwhEcowt1lcUDsZzPzbB 3Hgd/bvhEySWUfn3feQYtZCybDF0odxQFeZ22nAMqqUTpyQhDdIKmeUzhK3ziexiWT YwfESbEggNxu/ocNpVlMwAZtQsTso41KwNUsSZEQCDiB+/wUsRWV4QJ5VfV9oOtyBF FB/EGKFh77Orw== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 602374408C4; Thu, 14 Sep 2023 09:44:01 -0400 (EDT) Original-Received: from pastel (unknown [104.247.229.91]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 3F1551202AD; Thu, 14 Sep 2023 09:44:01 -0400 (EDT) In-Reply-To: <86zg1puupr.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 14 Sep 2023 09:39:48 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270426 Archived-At: >>> Anyway, here is a patch with two fixes: >>> 1. Guards read-char-from-minibuffer-insert-char against inadvertent >>> operating on the non-minibuffer buffer; >> I suspect this will/would just hide a problem (such as the current one) >> under the rug. > I admit this is a workaround, but I have no idea what would be a proper fix. The let-binding of `this-command` fixes the problem, doesn't it? >>> 2. Prevents read-char-from-minibuffer from changing the value of >>> 'this-command' by read-from-minibuffer: >> Right, but I think that this needs to apply to all recursive edits >> rather than only `read-char-from-minibuffer`. > I tried to test recursive commands at the read-char-from-minibuffer's > prompt, but can't reproduce the same problem. No, I mean other uses of a recursive edit from `pre-command-hook` would cause the same problem, so the let-binding should be placed deeper than in `read-char-from-minibuffer`, e.g. inside `recursive_edit_1`. Stefan