From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#60845: 30.0.50; [PATCH] Add tests for Eshell interactive completion (and fix a bug in it) Date: Tue, 10 Oct 2023 17:23:42 -0400 Message-ID: References: <2b75d4d4-0533-2182-6da8-413391577bf5@gmail.com> <40d31b3d-d429-5a48-02bc-a3c1e4a1d903@gmail.com> <8f725450-1158-67de-7a0f-d550d867e084@gmail.com> <990abf69-d2f9-7582-c4dd-fd6bdebf04b3@gmail.com> <46c56cb6-deff-bc8f-7d29-9401b7d261b1@gmail.com> <488af1f4-f075-09e8-3b45-1d1a65266c68@gmail.com> <5c5c40d0-34f4-34ff-6cdd-9a2852ee97b4@gmail.com> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16765"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 60845-done@debbugs.gnu.org, Daniel Mendler , Gregory Heytings , arstoffel@gmail.com, Stefan Kangas To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 10 23:27:02 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qqKFp-00045P-QT for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 10 Oct 2023 23:27:02 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qqKFZ-0001EB-Uk; Tue, 10 Oct 2023 17:26:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqKFV-0001Cq-Nk for bug-gnu-emacs@gnu.org; Tue, 10 Oct 2023 17:26:41 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qqKFU-0008EB-Vk for bug-gnu-emacs@gnu.org; Tue, 10 Oct 2023 17:26:41 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qqKFq-0004I0-0d for bug-gnu-emacs@gnu.org; Tue, 10 Oct 2023 17:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 10 Oct 2023 21:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60845 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60845-done@debbugs.gnu.org id=D60845.169697316416401 (code D ref 60845); Tue, 10 Oct 2023 21:27:01 +0000 Original-Received: (at 60845-done) by debbugs.gnu.org; 10 Oct 2023 21:26:04 +0000 Original-Received: from localhost ([127.0.0.1]:37011 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqKEu-0004GS-BH for submit@debbugs.gnu.org; Tue, 10 Oct 2023 17:26:04 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:16372) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqKEq-0004Fu-Ib for 60845-done@debbugs.gnu.org; Tue, 10 Oct 2023 17:26:03 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id EAB591000AD; Tue, 10 Oct 2023 17:25:32 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1696973131; bh=yoUQ6XcySzLsk4rDzopOlL6qXxCYbTJPrCWc+W3be+c=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=G36XlcQ2t6t6IEJwhxBuasGPlRwjPWVF0ymye48EzR7Kj7NdohKgYqoB/W4s6dx8z gujZZCUf0GLzBZv6CwgASKusFGOQIpAvb7a7YGOkhmA6aG4f0UYmrUUvyXsF465I4A Muh0FAEO92jN4gQAImCISSmvVRF9zuBDgrZBy152bk+5fd8PRvEpwMPwJb87otRiyf jEwjrss9APgh0edGDvWIDVKwPJrnyIj9n0PPylqags/IPXVyAFWnk8M7x0aMpZuwuZ u7kp6+hH0TuUGV9FeViTJgeSJeDrd7rS2UjBUC/4EhSGMOKR8UVPyhRKFjip1JLoUg zLAyQq2HjZRmg== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id D121B100033; Tue, 10 Oct 2023 17:25:31 -0400 (EDT) Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id BAC061201CB; Tue, 10 Oct 2023 17:25:31 -0400 (EDT) In-Reply-To: <5c5c40d0-34f4-34ff-6cdd-9a2852ee97b4@gmail.com> (Jim Porter's message of "Tue, 10 Oct 2023 13:07:50 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:272234 Archived-At: >> Attached is a patch to revert the Emacs 29 workarounds. I *believe* I've >> fixed this on the Eshell side by always providing Pcomplete with the >> arguments in their string form. Could everyone try the patch out to make >> sure things still work? >> In particular, see the cases in the following bugs: bug#60464, bug#60021, >> and bug#59956. > > Since there have been no further comments in the last month, I've now merged > my patch to the master branch as 239db5d5162. If anyone sees any issues > resulting from this, feel free to back it out, file a bug, and/or let me > know directly. Thanks Jim, Stefan