From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#67005: 30.0.50; improve nadivce/comp/trampoline handling Date: Tue, 21 Nov 2023 17:18:13 -0500 Message-ID: References: <874jhv9921.fsf@sappc2.fritz.box> <875y24zrt1.fsf@sappc2.fritz.box> <87ttpmwuxi.fsf@sappc2.fritz.box> <877cmct4a1.fsf@sappc2.fritz.box> <87bkbmiwpf.fsf@sappc2.fritz.box> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36942"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: andrea corallo , 67005@debbugs.gnu.org To: Jens Schmidt Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 21 23:19:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r5Z5R-0009Le-Rc for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 21 Nov 2023 23:19:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r5Z5D-0006Zo-Kl; Tue, 21 Nov 2023 17:19:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r5Z5B-0006V9-9U for bug-gnu-emacs@gnu.org; Tue, 21 Nov 2023 17:19:01 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r5Z5A-0002k5-3Y for bug-gnu-emacs@gnu.org; Tue, 21 Nov 2023 17:19:00 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r5Z5C-0000Y7-Gc for bug-gnu-emacs@gnu.org; Tue, 21 Nov 2023 17:19:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 21 Nov 2023 22:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67005 X-GNU-PR-Package: emacs Original-Received: via spool by 67005-submit@debbugs.gnu.org id=B67005.17006051062067 (code B ref 67005); Tue, 21 Nov 2023 22:19:02 +0000 Original-Received: (at 67005) by debbugs.gnu.org; 21 Nov 2023 22:18:26 +0000 Original-Received: from localhost ([127.0.0.1]:57597 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r5Z4c-0000XG-1h for submit@debbugs.gnu.org; Tue, 21 Nov 2023 17:18:26 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:2152) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r5Z4a-0000X4-BM for 67005@debbugs.gnu.org; Tue, 21 Nov 2023 17:18:24 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 0A1AD1000AD; Tue, 21 Nov 2023 17:18:16 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1700605095; bh=xAcH7IqunUpG2JmFM+tMnQH10AxVF4PiOhcOSBywa/0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=cVd2W5BD80MqZh1MAzu6YjBpCxcVvuU6Pacp7cIlzVmmkoVm/oWvQbbLubm2DNB+f 6t7tFAjsWZclR4R9aszjFD7l5Xz/Megkck8B06tRR2VCb0IDLaElwT0IKhOBaTq/wF pkoFKleXv9WU7lP4bpu9rcnQ5cYYY6AItDGZD6bAabE4pPu27YQUKjaHbN8yn54+S0 BWyPS04mMjtEKVHmWdXpBQfkbNa6Yvywl/KCQ1VWpZuLc+zlpDzXk4jhtGQBHahCjR XMnQsIMi504yY9M8JjjdreVWq3mK/mzPVEOROEA7S0ZPQXa0S0N8glLh6mgWqDSRbF d25AdN31mP1eQ== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 559FF100043; Tue, 21 Nov 2023 17:18:15 -0500 (EST) Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 41B6612043F; Tue, 21 Nov 2023 17:18:15 -0500 (EST) In-Reply-To: <87bkbmiwpf.fsf@sappc2.fritz.box> (Jens Schmidt's message of "Tue, 21 Nov 2023 23:10:52 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274743 Archived-At: > Only slightly off-topic: When changing the default value of user option > `native-comp-never-optimize-functions', which now both Andrea and I have > done, does one also need to bump the :version? Or is this taken care of > automagically? If it needs to be done manually, to which value should > we/I set it? I guess you should change it to the version in which the new value will be released (i.e. "30.1"). > And here is another comment question: Do you think this snippet that > made me so upset: > > (let* ((f (if (symbolp callee) > (symbol-function callee) > (cl-assert (byte-code-function-p callee)) > callee)) > (subrp (subrp f)) > (comp-func-callee (comp-func-in-unit callee))) > > deserves some explanation? A comment would make sense, since the code got you confused, yes. Stefan