From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#67568: Emacs master: Bug in byte compiler when there's an unused parameter. Date: Sun, 03 Dec 2023 14:24:44 -0500 Message-ID: References: <1c2d9219-093c-0726-13ce-2c952f6e33ba@gutov.dev> <83il5f6yuz.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5072"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: dmitry@gutov.dev, acm@muc.de, 67568-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 03 20:26:10 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r9s6U-00016l-8S for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 03 Dec 2023 20:26:10 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r9s6I-0002Kn-EM; Sun, 03 Dec 2023 14:25:59 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r9s6D-0002Jw-Kv for bug-gnu-emacs@gnu.org; Sun, 03 Dec 2023 14:25:54 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r9s6C-0004sM-O8 for bug-gnu-emacs@gnu.org; Sun, 03 Dec 2023 14:25:53 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r9s6M-0004r9-Ee for bug-gnu-emacs@gnu.org; Sun, 03 Dec 2023 14:26:02 -0500 Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Dec 2023 19:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 67568 X-GNU-PR-Package: emacs Mail-Followup-To: 67568@debbugs.gnu.org, monnier@iro.umontreal.ca, acm@muc.de Original-Received: via spool by 67568-done@debbugs.gnu.org id=D67568.170163150618585 (code D ref 67568); Sun, 03 Dec 2023 19:26:02 +0000 Original-Received: (at 67568-done) by debbugs.gnu.org; 3 Dec 2023 19:25:06 +0000 Original-Received: from localhost ([127.0.0.1]:32790 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r9s5R-0004pg-KA for submit@debbugs.gnu.org; Sun, 03 Dec 2023 14:25:05 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:24099) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r9s5O-0004p7-P4 for 67568-done@debbugs.gnu.org; Sun, 03 Dec 2023 14:25:04 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id EB292442C7E; Sun, 3 Dec 2023 14:24:46 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1701631485; bh=Je5e5/YSRSB3CUE3jQQBXNbrQEHmsEBmRux1ZbAxh3Y=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=T8N9ocmGy1qRxXL3UcPBEuvqApAr1Xz63EOf0/q1Etax9EczWpQZ0EwgqKsIS6KM1 dVzIamTvho3gliLte8d51u0k1J74WnslrGEJVgSP/av+uN6Rn5g/xEFueCbqFSrPGM xzTZsRATYqI5r3GgwQWK/nHwCoosJMZosxH75T/Z8aZKjT+2O0n48CoFMuP/MkbRnw aj8V2oNa8QwAzizcnp/2X9ipagS0+ZAFU32Ae91dPbJVk9kQDBlMKe+kjIYMnqLHcs WAl9yBorTnxJW1KdMhjPD+xh7NR0sG+PYuZmIpFMIbacubtwbm/P7815FPRvlY3LfR vdhAZL8IDwzjw== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id C76A6442C7B; Sun, 3 Dec 2023 14:24:45 -0500 (EST) Original-Received: from alfajor (unknown [45.72.194.97]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 706A21202FF; Sun, 3 Dec 2023 14:24:45 -0500 (EST) In-Reply-To: <83il5f6yuz.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 03 Dec 2023 18:21:24 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275449 Archived-At: >> I'm wondering whether it should go to `emacs-29` or to `master`. >> I'm leaning toward `emacs-29` because it's rather embarrassing (and >> perplexing for the user) and the patch is simple. >> Eli? Stefan? > No objections from me. It turns out the bug is not present in `emacs-29`, it was introduced on master by: commit f616edb4ccce5b9d60e3ff42806bd2131989cd1e Author: Mattias Engdeg=E5rd Date: Mon Sep 25 14:40:11 2023 +0200 macroexp-parse-body: correct parsing of empty body (bug#66136) =20=20=20=20 * lisp/emacs-lisp/macroexp.el (macroexp-parse-body): Return an empty body even when there are declarations present. Previously, the last declaration was considered part of the body, which is only correct if the input consists of a single string. =20=20=20=20 Reported by Jens Schmidt. So I pushed a better fix, on master. Stefan