unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Eshel Yaron <me@eshelyaron.com>, 74091@debbugs.gnu.org
Subject: bug#74091: 31.0.50; string-pixel-width in mode line disables region
Date: Sat, 09 Nov 2024 11:26:48 -0500	[thread overview]
Message-ID: <jwved3kz8iu.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <86ed3w33g1.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 31 Oct 2024 13:41:02 +0200")

> Killing local variables makes the global value of deactivate-mark be
> in effect when the command loop decides whether to deactivate the
> region after a command finishes.

The thing I don't understand is this:

    Why is the global value of `deactivate-mark` non-nil?

After all, since it is buffer-local when set, it should only be non-nil
buffer-locally, so the `kill-all-local-variables` should just through
away the non-nil setting, whereas it seems that somehow the non-nil
setting gets "promoted" to global.

I suspect the problem might be a bug in `reset_buffer_local_variables` around:

    /* Reset all (or most) per-buffer variables to their defaults.  */
    if (permanent_too)
      bset_local_var_alist (b, Qnil);

I suspect this was OK in the "original" uses of `permanent_too` because
"by construction" none of those vars could be "swapped in" (i.e. have
their value held in a C variable like `Vdeactivate_mark`), but we now
have cases where this is not the case any more, so that if the value of
`Vdeactivate_mark` held a buffer-local value, it ends up "promoted"
to global.


        Stefan






  parent reply	other threads:[~2024-11-09 16:26 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-29 17:27 bug#74091: 31.0.50; string-pixel-width in mode line disables region Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-30 14:59 ` Eli Zaretskii
2024-10-30 15:26   ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-30 16:01     ` Eli Zaretskii
2024-10-31 11:09       ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-31 11:41         ` Eli Zaretskii
2024-10-31 12:24           ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-31 14:35             ` Eli Zaretskii
2024-11-06  8:01               ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-11-06 12:49                 ` Eli Zaretskii
2024-11-06 14:12                   ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-11-09 11:13                     ` Eli Zaretskii
2024-11-09 16:26           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-11-09 16:37             ` Eli Zaretskii
2024-11-09 18:06               ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-11-09 18:14                 ` Eli Zaretskii
2024-11-09 18:35                   ` Eli Zaretskii
2024-11-09 22:11                     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-11-10  5:50                       ` Eli Zaretskii
2024-11-10  6:50                         ` Eli Zaretskii
2024-11-10 10:42                           ` Eli Zaretskii
2024-11-10 16:46                             ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-11-10 19:17                               ` Eli Zaretskii
2024-11-10 20:19                                 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-11-11  3:22                                   ` Eli Zaretskii
2024-11-11  6:52                                     ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwved3kz8iu.fsf-monnier+emacs@gnu.org \
    --to=bug-gnu-emacs@gnu.org \
    --cc=74091@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=me@eshelyaron.com \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).