From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#73853: 31.0.50; Should and-let* become a synonym for when-let*? Date: Fri, 22 Nov 2024 14:46:30 -0500 Message-ID: References: <87a5f2xir8.fsf@web.de> <87froszrs6.fsf@melete.silentflame.com> <87ed48b3er.fsf_-_@melete.silentflame.com> <87a5ew5few.fsf@web.de> <878qud7uj7.fsf@melete.silentflame.com> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7774"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Michael Heerdegen , Stefan Kangas , 73853@debbugs.gnu.org To: Sean Whitton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 22 20:47:20 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tEZcd-0001sk-PD for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 22 Nov 2024 20:47:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tEZcQ-0000lW-E9; Fri, 22 Nov 2024 14:47:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tEZcM-0000lI-Pk for bug-gnu-emacs@gnu.org; Fri, 22 Nov 2024 14:47:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tEZcM-0007d7-HO for bug-gnu-emacs@gnu.org; Fri, 22 Nov 2024 14:47:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=AS5sKbzVIycNvF43FTRZMcIuzfxdtJa7qBWLbO6QH5g=; b=O7dNIUugdcwkFOwhegPrKLpC5JgGoJzzK11C2eRcIqSWQnFCIsJ+gaJSwyNPNCPg8wG8W/AYRYCwKHvJYH/+/ahK0xKjnMi0s0KUikq5BmjRFqCXEMq58JVa91q++1QK8dzv+uIAsMQtFYjvcInVCJROlRNf5f1t532L6sp2GraPF7gt5fj/NRFoa1GfDGG/YXYIr7we3556UpL7JD4AnIbJOpyOEvXs7O0NppCbhRFSNWaWPqNBgjb7cp1ulF7CMu7y7VLK2L6zlaben1Zy/M1gV2sQqIQMnAcUiG5o1vaC7Elzo/LubTtfRc/O80cGFNYJ/CzffpDWAuxVOdYkhA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tEZcM-0005Co-6H for bug-gnu-emacs@gnu.org; Fri, 22 Nov 2024 14:47:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Nov 2024 19:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73853 X-GNU-PR-Package: emacs Original-Received: via spool by 73853-submit@debbugs.gnu.org id=B73853.173230481119983 (code B ref 73853); Fri, 22 Nov 2024 19:47:02 +0000 Original-Received: (at 73853) by debbugs.gnu.org; 22 Nov 2024 19:46:51 +0000 Original-Received: from localhost ([127.0.0.1]:55640 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tEZcA-0005CA-Uu for submit@debbugs.gnu.org; Fri, 22 Nov 2024 14:46:51 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:27223) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tEZc8-0005Bt-LL for 73853@debbugs.gnu.org; Fri, 22 Nov 2024 14:46:49 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 099C41007C7; Fri, 22 Nov 2024 14:46:42 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1732304797; bh=EBECb0/RZ8kWTI4nQJxJyWaLd0AHTQnyCGq8vAR8z4U=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=U657K0ZCGQZ0yP/1aUcv1JjsHly061fe3lpE8mz5eDpol1yScYkRzkHmn3I8mWaa/ ZbdWJ6TjTB4mFCvpC6oBhGZOIuTfnNzVnKtc3JNj2j7CBIgskTArqpdGVV7lMPFkal UWTofGfAyIofNiR6EF+qER6HV5OlAGPrzHe31rPLHjKqS5/GBx/TeWFlQ4Gv4bpoGW c56al3fmMRRJrFKrQ+Yp03/n9n+B2ZTuHDO90K5FepCQoXHyBWnpbDNcYZ8siqEsBp NWolccdyG1i6btH5EhC5V8N6Uskxt04La4OFTIhiAA8RLy804Fmp1hcdY/UUeqFNXV xHzS+ZlowUlFQ== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 2D7CB100417; Fri, 22 Nov 2024 14:46:37 -0500 (EST) Original-Received: from alfajor (unknown [10.35.228.139]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 1D6AD120494; Fri, 22 Nov 2024 14:46:37 -0500 (EST) In-Reply-To: <878qud7uj7.fsf@melete.silentflame.com> (Sean Whitton's message of "Thu, 24 Oct 2024 16:51:56 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295801 Archived-At: >>>> - I'd like to go ahead and install a patch marking when-let and if-l= et >>>> as obsolete, unless Michael is keen to be the one to do it as the >>>> initiator of the previous effort [...] > Done. Beside the use of `make-obsolete` instead of putting the `obsolete` inside `declare`, I see a more serious problem with this patch. E.g. (defun my-foo () (when-let ((x (point))) (goto-char x))) gives 2 warnings rather than one: In my-foo: foo.el:3:19: Warning: =E2=80=98when-let=E2=80=99 is an obsolete macro (= as of 31.1); use =E2=80=98when-let*=E2=80=99 or =E2=80=98and-let*=E2=80=99 instead. foo.el:3:2: Warning: =E2=80=98if-let=E2=80=99 is an obsolete macro (as = of 31.1); use =E2=80=98if-let*=E2=80=99 instead. - Stefan