From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel,gmane.emacs.bugs Subject: Re: bug in minibuffer-complete-and-exit, fix included Date: Tue, 27 Dec 2005 11:36:47 -0500 Message-ID: References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1135701436 8902 80.91.229.2 (27 Dec 2005 16:37:16 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 27 Dec 2005 16:37:16 +0000 (UTC) Cc: bug-gnu-emacs@gnu.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 27 17:37:16 2005 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1ErHox-0000U3-WB for ged-emacs-devel@m.gmane.org; Tue, 27 Dec 2005 17:37:10 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ErHqE-00048w-2A for ged-emacs-devel@m.gmane.org; Tue, 27 Dec 2005 11:38:26 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ErHq3-00048k-I2 for emacs-devel@gnu.org; Tue, 27 Dec 2005 11:38:15 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ErHq0-000486-4n for emacs-devel@gnu.org; Tue, 27 Dec 2005 11:38:15 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ErHpy-00047g-00; Tue, 27 Dec 2005 11:38:10 -0500 Original-Received: from [132.204.24.67] (helo=mercure.iro.umontreal.ca) by monty-python.gnu.org with esmtp (Exim 4.34) id 1ErHpz-0001XE-Cy; Tue, 27 Dec 2005 11:38:11 -0500 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 95AB333E604; Tue, 27 Dec 2005 11:36:50 -0500 (EST) Original-Received: from asado.iro.umontreal.ca (asado.iro.umontreal.ca [132.204.24.84]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 4F1F54AC00A; Tue, 27 Dec 2005 11:36:47 -0500 (EST) Original-Received: by asado.iro.umontreal.ca (Postfix, from userid 20848) id 3A3B5E6C20; Tue, 27 Dec 2005 11:36:47 -0500 (EST) Original-To: Ryan Barrett In-Reply-To: (Ryan Barrett's message of "Tue, 27 Dec 2005 00:38:38 -0800 (PST)") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-4.854, requis 5, autolearn=not spam, AWL 0.05, BAYES_00 -4.90) X-MailScanner-From: monnier@iro.umontreal.ca X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:48410 gmane.emacs.bugs:14679 Archived-At: > *** minibuf.c 21 Dec 2005 17:33:40 -0000 1.297 > --- minibuf.c 27 Dec 2005 07:39:07 -0000 > *************** > *** 2139,2145 **** > if (STRINGP (compl) > /* If it weren't for this piece of paranoia, I'd replace > the whole thing with a call to do_completion. */ > ! && EQ (Flength (val), Flength (compl))) > { > del_range (XINT (Fminibuffer_prompt_end ()), ZV); > Finsert (1, &compl); > --- 2139,2145 ---- > if (STRINGP (compl) > /* If it weren't for this piece of paranoia, I'd replace > the whole thing with a call to do_completion. */ > ! && EQ (XFASTINT (Flength (val)), XFASTINT (Flength (compl)))) > { > del_range (XINT (Fminibuffer_prompt_end ()), ZV); > Finsert (1, &compl); This patch doesn't make any sense: EQ takes two args of type Lisp_Object (which is also the type returned by Flength), whereas XFASTINT takes a Lisp_Object and returns an int. Now, if you say it fixes your problem in your test case, I believe you, but it's probably just happenstance. ho I must say I can't figure out how that could happen here ;-) Stefan