unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: bug-gnu-emacs@gnu.org, emacs-devel@gnu.org
Subject: Re: bug in minibuffer-complete-and-exit, fix included
Date: Tue, 27 Dec 2005 11:36:47 -0500	[thread overview]
Message-ID: <jwvd5jicxha.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0512262326110.18163@davis.corp.google.com> (Ryan Barrett's message of "Tue, 27 Dec 2005 00:38:38 -0800 (PST)")

> *** minibuf.c       21 Dec 2005 17:33:40 -0000      1.297
> --- minibuf.c       27 Dec 2005 07:39:07 -0000
> ***************
> *** 2139,2145 ****
>            if (STRINGP (compl)
>                /* If it weren't for this piece of paranoia, I'd replace
>                   the whole thing with a call to do_completion. */
> !             && EQ (Flength (val), Flength (compl)))
>              {
>                del_range (XINT (Fminibuffer_prompt_end ()), ZV);
>                Finsert (1, &compl);
> --- 2139,2145 ----
>            if (STRINGP (compl)
>                /* If it weren't for this piece of paranoia, I'd replace
>                   the whole thing with a call to do_completion. */
> !             && EQ (XFASTINT (Flength (val)), XFASTINT (Flength (compl))))
>              {
>                del_range (XINT (Fminibuffer_prompt_end ()), ZV);
>                Finsert (1, &compl);

This patch doesn't make any sense: EQ takes two args of type Lisp_Object
(which is also the type returned by Flength), whereas XFASTINT takes
a Lisp_Object and returns an int.

Now, if you say it fixes your problem in your test case, I believe you, but
it's probably just happenstance.  ho I must say I can't figure out how that
could happen here ;-)


        Stefan

  reply	other threads:[~2005-12-27 16:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-27  8:38 bug in minibuffer-complete-and-exit, fix included Ryan Barrett
2005-12-27 16:36 ` Stefan Monnier [this message]
2005-12-28 20:19   ` Ryan Barrett
2005-12-29  3:13     ` Stefan Monnier
2005-12-29 17:10     ` Richard M. Stallman
2005-12-31  1:49     ` Ryan Barrett
2005-12-27 18:27 ` Stefan Monnier
2005-12-27 18:51   ` Kevin Rodgers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvd5jicxha.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=bug-gnu-emacs@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).