From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#5162: 23.1.90; display-time broken in non-X build Date: Thu, 10 Dec 2009 14:09:46 -0500 Message-ID: References: <87y6lclc3q.fsf@turtle.gmx.de> <84d42nbmzg.fsf@fencepost.gnu.org> <87ws0v2kew.fsf@turtle.gmx.de> Reply-To: Stefan Monnier , 5162@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1260475635 15646 80.91.229.12 (10 Dec 2009 20:07:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 10 Dec 2009 20:07:15 +0000 (UTC) Cc: 5162@emacsbugs.donarmstrong.com To: Sven Joachim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 10 21:07:07 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NIpHz-00009f-77 for geb-bug-gnu-emacs@m.gmane.org; Thu, 10 Dec 2009 21:07:04 +0100 Original-Received: from localhost ([127.0.0.1]:49020 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NIpHy-00055M-Np for geb-bug-gnu-emacs@m.gmane.org; Thu, 10 Dec 2009 15:07:02 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NIofn-0002T3-DO for bug-gnu-emacs@gnu.org; Thu, 10 Dec 2009 14:27:35 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NIofi-0002Ob-F0 for bug-gnu-emacs@gnu.org; Thu, 10 Dec 2009 14:27:34 -0500 Original-Received: from [199.232.76.173] (port=33345 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NIofi-0002OF-7t for bug-gnu-emacs@gnu.org; Thu, 10 Dec 2009 14:27:30 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:38131) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NIofh-0002dy-N2 for bug-gnu-emacs@gnu.org; Thu, 10 Dec 2009 14:27:30 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nBAJRRDL012696; Thu, 10 Dec 2009 11:27:28 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id nBAJF4cD011486; Thu, 10 Dec 2009 11:15:04 -0800 Resent-Date: Thu, 10 Dec 2009 11:15:04 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Stefan Monnier Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Thu, 10 Dec 2009 19:15:04 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 5162 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 5162-submit@emacsbugs.donarmstrong.com id=B5162.126047219010965 (code B ref 5162); Thu, 10 Dec 2009 19:15:04 +0000 Original-Received: (at 5162) by emacsbugs.donarmstrong.com; 10 Dec 2009 19:09:50 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from chene.dit.umontreal.ca (chene.dit.umontreal.ca [132.204.246.20]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nBAJ9mXm010962 for <5162@emacsbugs.donarmstrong.com>; Thu, 10 Dec 2009 11:09:49 -0800 Original-Received: from faina.iro.umontreal.ca (faina.iro.umontreal.ca [132.204.26.177]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id nBAJ9lca024818; Thu, 10 Dec 2009 14:09:47 -0500 Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id E94CD3A008; Thu, 10 Dec 2009 14:09:46 -0500 (EST) In-Reply-To: <87ws0v2kew.fsf@turtle.gmx.de> (Sven Joachim's message of "Thu, 10 Dec 2009 11:27:51 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3425=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Thu, 10 Dec 2009 14:27:34 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:33473 Archived-At: > I see that you have already committed it, and it has definitely improved > the situation, but it is still necessary to run "make clean" when > re-configuring "--without-x" (before your patch, only the brute > "make maintainer-clean" would have done the trick). Hmm... indeed it seems that the normal build procedure runs `cd lisp; make autoloads' only when lisp/loaddefs.el is missing and doesn't otherwise update the file. The patch below should fix that, tho at the cost of making the autoloads twice in the bootstrap case. Can you confirm it fixes the problem? Assuming it does, I'm not sure whether we should use such a patch as is, or whether we should "do it right" Stefan --- Makefile.in.~1.213.~ 2009-12-01 12:51:45.000000000 -0500 +++ Makefile.in 2009-12-10 13:26:49.000000000 -0500 @@ -109,7 +109,7 @@ # with "make -j" and results in more deterministic compilation warnings. # cus-load and finder-inf are not explicitly requested by anything, so # we add them here to make sure they get built. -all: compile-main $(lisp)/cus-load.el $(lisp)/finder-inf.el +all: autoloads compile-main $(lisp)/cus-load.el $(lisp)/finder-inf.el @: Let us check that we byte-compiled all the files. $(MAKE) $(MFLAGS) compile-last EMACS=$(EMACS)