unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Sven Joachim <svenjoac@gmx.de>
Cc: 5162@emacsbugs.donarmstrong.com
Subject: bug#5162: 23.1.90; display-time broken in non-X build
Date: Thu, 10 Dec 2009 14:09:46 -0500	[thread overview]
Message-ID: <jwvd42m3gbz.fsf-monnier+emacsbugreports@gnu.org> (raw)
In-Reply-To: <87ws0v2kew.fsf@turtle.gmx.de> (Sven Joachim's message of "Thu, 10 Dec 2009 11:27:51 +0100")

> I see that you have already committed it, and it has definitely improved
> the situation, but it is still necessary to run "make clean" when
> re-configuring "--without-x" (before your patch, only the brute
> "make maintainer-clean" would have done the trick).

Hmm... indeed it seems that the normal build procedure runs
`cd lisp; make autoloads' only when lisp/loaddefs.el is missing and
doesn't otherwise update the file.

The patch below should fix that, tho at the cost of making the autoloads
twice in the bootstrap case.  Can you confirm it fixes the problem?
Assuming it does, I'm not sure whether we should use such a patch as is,
or whether we should "do it right"


        Stefan


--- Makefile.in.~1.213.~	2009-12-01 12:51:45.000000000 -0500
+++ Makefile.in	2009-12-10 13:26:49.000000000 -0500
@@ -109,7 +109,7 @@
 # with "make -j" and results in more deterministic compilation warnings.
 # cus-load and finder-inf are not explicitly requested by anything, so
 # we add them here to make sure they get built.
-all: compile-main $(lisp)/cus-load.el $(lisp)/finder-inf.el
+all: autoloads compile-main $(lisp)/cus-load.el $(lisp)/finder-inf.el
 	@: Let us check that we byte-compiled all the files.
 	$(MAKE) $(MFLAGS) compile-last EMACS=$(EMACS)
 





  reply	other threads:[~2009-12-10 19:09 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-09  9:40 bug#5162: 23.1.90; display-time broken in non-X build Sven Joachim
2009-12-10  2:07 ` Glenn Morris
2009-12-10  4:07   ` Stefan Monnier
2009-12-10  5:03     ` Glenn Morris
2009-12-10  7:58       ` Stefan Monnier
2009-12-10 10:27         ` Sven Joachim
2009-12-10 19:09           ` Stefan Monnier [this message]
2009-12-10 22:22             ` Sven Joachim
2009-12-22  3:38               ` Glenn Morris
2009-12-10  9:22   ` Andreas Schwab
2009-12-10 17:09     ` Stefan Monnier
2009-12-10 17:17       ` Andreas Schwab
2009-12-10 18:51     ` Eli Zaretskii
2009-12-10 18:59       ` Glenn Morris
2009-12-10 19:09         ` Eli Zaretskii
2010-04-01 17:06 ` Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvd42m3gbz.fsf-monnier+emacsbugreports@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=5162@emacsbugs.donarmstrong.com \
    --cc=svenjoac@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).