From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#8399: 23.3; save-some-buffers ignores buffer names Date: Thu, 31 Mar 2011 21:01:05 -0400 Message-ID: References: <83y63vm0v4.fsf@cs.bham.ac.uk> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1301620054 32523 80.91.229.12 (1 Apr 2011 01:07:34 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 1 Apr 2011 01:07:34 +0000 (UTC) Cc: 8399@debbugs.gnu.org To: Uday S Reddy Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 01 03:07:30 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Q5Spl-0002BU-7a for geb-bug-gnu-emacs@m.gmane.org; Fri, 01 Apr 2011 03:07:29 +0200 Original-Received: from localhost ([127.0.0.1]:44023 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q5Spk-00089j-Jw for geb-bug-gnu-emacs@m.gmane.org; Thu, 31 Mar 2011 21:07:28 -0400 Original-Received: from [140.186.70.92] (port=40522 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q5Spc-00088k-Lu for bug-gnu-emacs@gnu.org; Thu, 31 Mar 2011 21:07:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q5Spa-0001Aq-Cx for bug-gnu-emacs@gnu.org; Thu, 31 Mar 2011 21:07:20 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38937) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q5Spa-0001Al-A7 for bug-gnu-emacs@gnu.org; Thu, 31 Mar 2011 21:07:18 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Q5SkU-0000LK-37; Thu, 31 Mar 2011 21:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Apr 2011 01:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8399 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 8399-submit@debbugs.gnu.org id=B8399.13016196751261 (code B ref 8399); Fri, 01 Apr 2011 01:02:02 +0000 Original-Received: (at 8399) by debbugs.gnu.org; 1 Apr 2011 01:01:15 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q5Sji-0000KI-HA for submit@debbugs.gnu.org; Thu, 31 Mar 2011 21:01:14 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.183] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q5Sjh-0000K6-2v for 8399@debbugs.gnu.org; Thu, 31 Mar 2011 21:01:13 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEAHwilU1FxKsL/2dsb2JhbAClWXiIebgqhWsEli2DTA X-IronPort-AV: E=Sophos;i="4.63,279,1299474000"; d="scan'208";a="99403237" Original-Received: from 69-196-171-11.dsl.teksavvy.com (HELO pastel.home) ([69.196.171.11]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 31 Mar 2011 21:01:06 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id D417958F8C; Thu, 31 Mar 2011 21:01:05 -0400 (EDT) In-Reply-To: <83y63vm0v4.fsf@cs.bham.ac.uk> (Uday S. Reddy's message of "Thu, 31 Mar 2011 22:33:19 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Thu, 31 Mar 2011 21:02:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:45553 Archived-At: > The attached patch (on Emacs-23 head) modifies the dialogue so that > file-names are used in the dialogue only when they coincide with the > buffer names. Otherwise, buffer names are used preferentially. I think the file-name is only useful when you have buffer "file", "file<2>", "file<3>", ... so your check is going in the right direction but it should also use file-name when the buffer name matches (concat "\\<" (regexp-quote (file-name-nondirectory buffer-file-name)) "<[0-9]+>\\'"), and it should never use file-names when uniquify is used. IMNSHO, Stefan