From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 8771@debbugs.gnu.org
Subject: bug#8771: Remove arbitrary 32-bit limit in Emacs hash tables
Date: Tue, 31 May 2011 10:03:28 -0300 [thread overview]
Message-ID: <jwvd3izt46r.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <4DE4861E.709@cs.ucla.edu> (Paul Eggert's message of "Mon, 30 May 2011 23:09:34 -0700")
> Currently the Emacs source code uses 'unsigned' for hashes and 'int'
> for hash tables, but on 64-bit hosts hash tables can in principle be
> larger than what can be shoehorned into 32 bits. Here's a proposed patch;
> most of it is pretty straightforward.
Sounds fine to me. Style suggestions (really, nothing more than
suggestions) below.
Stefan
> Remove arbitrary limit of 2**31 entries in hash tables.
> * category.c (hash_get_category_set): Use 'EMACS_UINT' and 'EMACS_INT'
> for hashes and hash indexes, instead of 'unsigned' and 'int'.
> * ccl.c (ccl_driver): Likewise.
> * charset.c (Fdefine_charset_internal): Likewise.
> * charset.h (struct charset.hash_index): Likewise.
> * composite.c (get_composition_id, gstring_lookup_cache):
> (composition_gstring_put_cache): Likewise.
Rather than "Likewise" you can use the following format:
Remove arbitrary limit of 2**31 entries in hash tables.
* category.c (hash_get_category_set):
* ccl.c (ccl_driver):
* charset.c (Fdefine_charset_internal):
* charset.h (struct charset.hash_index):
* composite.c (get_composition_id, gstring_lookup_cache):
(composition_gstring_put_cache): Use 'EMACS_UINT' and 'EMACS_INT'
for hashes and hash indexes, instead of 'unsigned' and 'int'.
And rather than
* composite.c (get_composition_id, gstring_lookup_cache):
(composition_gstring_put_cache): Foobar.
we usually write:
* composite.c (get_composition_id, gstring_lookup_cache)
(composition_gstring_put_cache): Foobar.
next prev parent reply other threads:[~2011-05-31 13:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-31 6:09 bug#8771: Remove arbitrary 32-bit limit in Emacs hash tables Paul Eggert
2011-05-31 13:03 ` Stefan Monnier [this message]
2011-05-31 14:50 ` bug#8771: vc-dwim problem parsing ChangeLog entries (was: Emacs bug#8771) Paul Eggert
2011-05-31 21:43 ` bug#8771: [Bug-vc-dwim] vc-dwim problem parsing ChangeLog entries Jim Meyering
[not found] ` <handler.8771.B.130682219719090.ack@debbugs.gnu.org>
2011-06-02 8:05 ` bug#8771: Acknowledgement (Remove arbitrary 32-bit limit in Emacs hash tables) Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvd3izt46r.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=8771@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).