From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: Kevin Rodgers <kevin.d.rodgers@gmail.com>, 6339@debbugs.gnu.org
Subject: bug#6339: url-filename => "/c:/some/file.txt"
Date: Thu, 06 Oct 2011 17:08:58 -0400 [thread overview]
Message-ID: <jwvd3e9bzi5.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CAAeL0SRDcEe4qstva5jEpNtFamp+hBqkfs0uZW3uUDwSgpKeVA@mail.gmail.com> (Juanma Barranquero's message of "Thu, 6 Oct 2011 18:54:21 +0200")
>> But the patch you sent changes url-generic-parse-url so it presumably
>> can affect many more places that just those that call url-filename.
> url-generic-parse-url returns a url struct, and url-filename is the
> accessor for the slot. If there's code that uses the slot without
> going through the accessor, well... I think that's a bug (or, at the
> very least, dangerous and ugly) and sooner or later we'll find
> about it.
Sorry, yes, the above paragraph was written before I remembered that
url-filename was an accessor. I just forgot to erase it before sending.
>> I think it's the right thing to do. But maybe the best patch will need
>> to rename the `filename' slot and to define url-filename to do the
>> (expand-file-name (url-somethingelse URL) "/") or something like that.
> I don't think you can do that, because, as explained before in the
> thread, splitting the URL and using its parts are independent actions.
> It is entirely possible to split a file URL and then use it in
> different systems, isn't it?
Let's not talk about that for now. Once there's a working patch
there'll be less chance for confusion.
Stefan
next prev parent reply other threads:[~2011-10-06 21:08 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-03 2:38 bug#6339: url-filename => "/c:/some/file.txt" Lennart Borgman
2010-06-03 11:13 ` Juanma Barranquero
2010-07-26 11:50 ` Juanma Barranquero
2010-07-26 12:00 ` Lennart Borgman
2010-08-01 18:46 ` Juanma Barranquero
2010-08-02 7:51 ` Michael Albinus
2011-09-21 20:28 ` Lars Magne Ingebrigtsen
2011-09-21 22:21 ` Juanma Barranquero
2011-09-21 22:31 ` Lennart Borgman
2011-09-21 22:45 ` Juanma Barranquero
2011-09-21 22:51 ` Lennart Borgman
2011-09-21 22:59 ` Juanma Barranquero
2011-09-21 23:15 ` Lennart Borgman
2011-09-21 23:18 ` Juanma Barranquero
2011-09-21 23:32 ` Lennart Borgman
2011-09-21 23:37 ` Juanma Barranquero
2011-09-21 23:46 ` Lennart Borgman
2011-09-22 0:32 ` Juanma Barranquero
2011-09-22 0:40 ` Lennart Borgman
2011-09-22 0:59 ` Juanma Barranquero
2011-09-22 1:07 ` Lennart Borgman
2011-09-22 1:14 ` Juanma Barranquero
2011-09-22 9:52 ` Lennart Borgman
2011-10-06 5:09 ` Kevin Rodgers
2011-10-06 11:56 ` Juanma Barranquero
2011-10-06 12:43 ` Stefan Monnier
2011-10-06 13:40 ` Juanma Barranquero
2011-10-06 14:24 ` Jason Rumney
2011-10-06 14:30 ` Juanma Barranquero
2011-10-06 14:38 ` Jason Rumney
2011-10-06 14:49 ` Juanma Barranquero
2011-10-06 15:08 ` Lennart Borgman
2011-10-06 15:08 ` Lennart Borgman
2011-10-06 15:31 ` Stefan Monnier
2011-10-06 15:56 ` Juanma Barranquero
2011-10-06 16:49 ` Stefan Monnier
2011-10-06 16:54 ` Juanma Barranquero
2011-10-06 21:08 ` Stefan Monnier [this message]
2011-09-24 3:35 ` Jason Rumney
2011-09-24 8:59 ` Juanma Barranquero
2011-09-24 9:06 ` Juanma Barranquero
2011-09-24 11:53 ` Andreas Schwab
2011-09-24 21:56 ` Juanma Barranquero
2011-09-24 23:42 ` Andreas Schwab
2011-09-25 0:02 ` Juanma Barranquero
2011-09-24 9:46 ` Lennart Borgman
2011-09-24 12:28 ` Richard Stallman
2012-05-09 9:04 ` Chong Yidong
2012-05-09 11:52 ` Juanma Barranquero
2012-05-10 14:15 ` Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvd3e9bzi5.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=6339@debbugs.gnu.org \
--cc=kevin.d.rodgers@gmail.com \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).