From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#12685: 24.2; lexical binding breaks edebug conditional breakpoints Date: Thu, 08 Aug 2013 19:19:07 -0400 Message-ID: References: <20130805151446.GA12256@c3po> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1376004021 20119 80.91.229.3 (8 Aug 2013 23:20:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 8 Aug 2013 23:20:21 +0000 (UTC) Cc: egnarts-ms , 12685@debbugs.gnu.org To: Toby Cubitt Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 09 01:20:22 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1V7ZVF-0000Dr-SE for geb-bug-gnu-emacs@m.gmane.org; Fri, 09 Aug 2013 01:20:21 +0200 Original-Received: from localhost ([::1]:57897 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V7ZVF-0003g3-7i for geb-bug-gnu-emacs@m.gmane.org; Thu, 08 Aug 2013 19:20:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47074) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V7ZV5-0003Rd-F9 for bug-gnu-emacs@gnu.org; Thu, 08 Aug 2013 19:20:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V7ZUy-0002fq-4w for bug-gnu-emacs@gnu.org; Thu, 08 Aug 2013 19:20:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53864) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V7ZUy-0002fO-1r for bug-gnu-emacs@gnu.org; Thu, 08 Aug 2013 19:20:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1V7ZUx-0006ku-2W for bug-gnu-emacs@gnu.org; Thu, 08 Aug 2013 19:20:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Aug 2013 23:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12685 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 12685-submit@debbugs.gnu.org id=B12685.137600395825892 (code B ref 12685); Thu, 08 Aug 2013 23:20:02 +0000 Original-Received: (at 12685) by debbugs.gnu.org; 8 Aug 2013 23:19:18 +0000 Original-Received: from localhost ([127.0.0.1]:48176 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V7ZUD-0006jV-QP for submit@debbugs.gnu.org; Thu, 08 Aug 2013 19:19:18 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:63575) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V7ZU9-0006jG-Tb for 12685@debbugs.gnu.org; Thu, 08 Aug 2013 19:19:16 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFLd/Nq/2dsb2JhbABEuzWDWRdzgh4BAQQBJy8jBQsLDiYSFBgNJIgeBsEtkQoDpHqBXoMTgUok X-IPAS-Result: Av8EABK/CFFLd/Nq/2dsb2JhbABEuzWDWRdzgh4BAQQBJy8jBQsLDiYSFBgNJIgeBsEtkQoDpHqBXoMTgUok X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="21142223" Original-Received: from 75-119-243-106.dsl.teksavvy.com (HELO pastel.home) ([75.119.243.106]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 08 Aug 2013 19:19:01 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id C7A2D62CCA; Thu, 8 Aug 2013 19:19:07 -0400 (EDT) In-Reply-To: <20130805151446.GA12256@c3po> (Toby Cubitt's message of "Mon, 5 Aug 2013 16:14:46 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:77113 Archived-At: > 3'. Create conditional breakpoint in `test': "C-x X x (null arg) " > 4'. Evaluate `test': "M-: (test 3)" > -> message "Symbol's value as variable is void: arg" I just installed the patch below which seems to fix this problem. Stefan === modified file 'lisp/emacs-lisp/edebug.el' --- lisp/emacs-lisp/edebug.el 2013-08-05 14:26:57 +0000 +++ lisp/emacs-lisp/edebug.el 2013-08-08 23:10:08 +0000 @@ -2314,8 +2314,7 @@ (if edebug-global-break-condition (condition-case nil (setq edebug-global-break-result - ;; FIXME: lexbind. - (eval edebug-global-break-condition)) + (edebug-eval edebug-global-break-condition)) (error nil)))) (edebug-break)) @@ -2326,8 +2325,7 @@ (and edebug-break-data (or (not edebug-break-condition) (setq edebug-break-result - ;; FIXME: lexbind. - (eval edebug-break-condition)))))) + (edebug-eval edebug-break-condition)))))) (if (and edebug-break (nth 2 edebug-break-data)) ; is it temporary? ;; Delete the breakpoint.