unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Glenn Morris <rgm@gnu.org>
Cc: 16859@debbugs.gnu.org
Subject: bug#16859: tty-setup-hook can run twice
Date: Wed, 26 Feb 2014 10:55:43 -0500	[thread overview]
Message-ID: <jwvd2i9oos2.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <yymwhede55.fsf@fencepost.gnu.org> (Glenn Morris's message of "Tue, 25 Feb 2014 17:24:38 -0500")

> 3) Add optional DO-NOT-RUN-HOOK (or the inverse) argument to
> tty-run-terminal-initialization.

I guess for backward compatibility's sake, adding a RUN-HOOK is a good idea.

> BTW, I also noticed that the hook runs when emacs --daemon is started,
> which seems odd?

Indeed, since we do

  (unless (or noninteractive
              initial-window-system)
    (tty-run-terminal-initialization (selected-frame)))

it would make sense to also prevent tty-run-terminal-initialization when
in daemon (tho I thought `noninteractive' would be set for daemon, but
maybe this is run late enough that `noninteractive' has already been
changed to nil by then).


        Stefan





      reply	other threads:[~2014-02-26 15:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-24  1:39 bug#16859: tty-setup-hook can run twice Glenn Morris
2014-02-25  9:06 ` Glenn Morris
2014-02-25 22:01   ` Stefan Monnier
2014-02-25 22:24     ` Glenn Morris
2014-02-26 15:55       ` Stefan Monnier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvd2i9oos2.fsf-monnier+emacsbugs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=16859@debbugs.gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).