From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#17148: 23.1; Revert Buffer Date: Tue, 01 Apr 2014 16:14:04 -0400 Message-ID: References: <201403311333.s2VDXNuJ029811@tbfmdev1.ctasdev.tc.faa.gov> <87ppl1v893.fsf@gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1396383330 21189 80.91.229.3 (1 Apr 2014 20:15:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 1 Apr 2014 20:15:30 +0000 (UTC) Cc: Michael Albinus , 17148@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 01 22:15:23 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WV55f-0005fD-9U for geb-bug-gnu-emacs@m.gmane.org; Tue, 01 Apr 2014 22:15:23 +0200 Original-Received: from localhost ([::1]:34221 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WV55e-0000A0-SQ for geb-bug-gnu-emacs@m.gmane.org; Tue, 01 Apr 2014 16:15:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35669) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WV55U-00006Y-5w for bug-gnu-emacs@gnu.org; Tue, 01 Apr 2014 16:15:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WV55L-00011D-VG for bug-gnu-emacs@gnu.org; Tue, 01 Apr 2014 16:15:12 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58571) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WV55L-00010f-Sk for bug-gnu-emacs@gnu.org; Tue, 01 Apr 2014 16:15:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WV55K-00023f-NP for bug-gnu-emacs@gnu.org; Tue, 01 Apr 2014 16:15:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Apr 2014 20:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17148 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug Original-Received: via spool by 17148-submit@debbugs.gnu.org id=B17148.13963832717844 (code B ref 17148); Tue, 01 Apr 2014 20:15:02 +0000 Original-Received: (at 17148) by debbugs.gnu.org; 1 Apr 2014 20:14:31 +0000 Original-Received: from localhost ([127.0.0.1]:59753 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WV54o-00022R-S8 for submit@debbugs.gnu.org; Tue, 01 Apr 2014 16:14:31 -0400 Original-Received: from mercure.iro.umontreal.ca ([132.204.24.67]:52754) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WV54m-00022H-8M for 17148@debbugs.gnu.org; Tue, 01 Apr 2014 16:14:28 -0400 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id D714784E0A; Tue, 1 Apr 2014 16:14:27 -0400 (EDT) Original-Received: from lechon.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 973111E5874; Tue, 1 Apr 2014 16:14:04 -0400 (EDT) Original-Received: by lechon.iro.umontreal.ca (Postfix, from userid 20848) id 71079B4128; Tue, 1 Apr 2014 16:14:04 -0400 (EDT) In-Reply-To: (Glenn Morris's message of "Tue, 01 Apr 2014 11:54:08 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82, MC_TSTLAST 0.00) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:87612 Archived-At: >> Emacs is not notified, when a file changes its state outside Emacs. Only >> prior to writing to a file Emacs checks, whether a file has changed on disk. > Why can't the revert-buffer menu-item check the file mode bits match, > the same way it verifies the modtime? IMO it should just call > file-attributes once, and use that to check time and permissions. Because revert-buffer is meant to handle the file's content, not its read-only setting. E.g. maybe the buffer is read-only because the user hit C-x C-q. Maybe we should use a 3rd setting for buffer-read-only which says "obey the file's writability". Stefan