unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 18141@debbugs.gnu.org, vincent@vinc17.net, yamaoka@jpl.org
Subject: bug#18141: 24.4.50; saving .gz file breaks file coding
Date: Thu, 07 Aug 2014 16:43:05 -0400	[thread overview]
Message-ID: <jwvd2cc6nlt.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <83r40sm6qo.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 07 Aug 2014 22:37:03 +0300")

> We could add a new optional argument to write-region to control
> whether backup is performed.

We could.  But I think write-region is already too big with too
many arguments.  I'd rather try to split it up into sub-components,
which is desirable in and of itself.

But that's just my preference, and I won't oppose a patch that takes
a different route.

> I think users generally expect this to be a transaction.  And at least
> on Posix platforms, where rename is an atomic operation, we can
> achieve this, or come pretty close.

I think the time-window is inevitable as long as we do "move first, then
write the new file".  Of course, we could do it the "precious"
way instead (i.e. write the new file first and then do the needed
link&unlink to move it into place).


        Stefan





  reply	other threads:[~2014-08-07 20:43 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-29  6:59 bug#18141: 24.4.50; saving .gz file breaks file coding Katsumi Yamaoka
2014-07-30  0:10 ` Glenn Morris
2014-07-30  2:36   ` Katsumi Yamaoka
2014-07-30 13:15     ` Katsumi Yamaoka
2014-08-05  8:34       ` Glenn Morris
2014-08-06 14:36         ` Eli Zaretskii
2014-08-06 16:43           ` Vincent Lefevre
2014-08-06 17:32             ` Eli Zaretskii
2014-08-06 19:08               ` Vincent Lefevre
2014-08-06 19:45                 ` Eli Zaretskii
2014-08-07  0:31                   ` Vincent Lefevre
2014-08-07 12:20                     ` Stefan Monnier
2014-08-07 14:23                       ` Vincent Lefevre
2014-08-11  1:06                         ` Glenn Morris
2014-08-06 17:48           ` Stefan Monnier
2014-08-06 18:10             ` Eli Zaretskii
2014-08-07  0:45               ` Stefan Monnier
2014-08-07 15:14                 ` Eli Zaretskii
2014-08-07 19:08                   ` Stefan Monnier
2014-08-07 19:37                     ` Eli Zaretskii
2014-08-07 20:43                       ` Stefan Monnier [this message]
2014-08-08  5:51                         ` Eli Zaretskii
2014-08-06 23:45           ` Glenn Morris
2014-08-07  0:03           ` Glenn Morris
2014-08-07 12:14             ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvd2cc6nlt.fsf-monnier+emacsbugs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=18141@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=vincent@vinc17.net \
    --cc=yamaoka@jpl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).