From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#20161: Fwd: Requesting review for change to lisp/textmodes/sgml-mode.el Date: Sun, 22 Mar 2015 10:03:59 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1427033125 16471 80.91.229.3 (22 Mar 2015 14:05:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 22 Mar 2015 14:05:25 +0000 (UTC) Cc: 20161@debbugs.gnu.org To: Jackson Hamilton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 22 15:05:15 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YZgV6-0004Bc-NE for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 Mar 2015 15:05:12 +0100 Original-Received: from localhost ([::1]:51142 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZgV6-0005u9-4R for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 Mar 2015 10:05:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35411) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZgV1-0005ri-R9 for bug-gnu-emacs@gnu.org; Sun, 22 Mar 2015 10:05:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YZgUw-0004x1-S4 for bug-gnu-emacs@gnu.org; Sun, 22 Mar 2015 10:05:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42719) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZgUw-0004wd-PZ for bug-gnu-emacs@gnu.org; Sun, 22 Mar 2015 10:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YZgUw-00007l-An for bug-gnu-emacs@gnu.org; Sun, 22 Mar 2015 10:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Mar 2015 14:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20161 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 20161-submit@debbugs.gnu.org id=B20161.1427033045406 (code B ref 20161); Sun, 22 Mar 2015 14:05:02 +0000 Original-Received: (at 20161) by debbugs.gnu.org; 22 Mar 2015 14:04:05 +0000 Original-Received: from localhost ([127.0.0.1]:60728 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YZgU1-00006U-06 for submit@debbugs.gnu.org; Sun, 22 Mar 2015 10:04:05 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:53466) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YZgTx-00005w-M7 for 20161@debbugs.gnu.org; Sun, 22 Mar 2015 10:04:02 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t2ME40D8005828; Sun, 22 Mar 2015 10:04:00 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id E3BD7145C; Sun, 22 Mar 2015 10:03:59 -0400 (EDT) In-Reply-To: (Jackson Hamilton's message of "Sat, 21 Mar 2015 13:20:09 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5253=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5253> : inlines <2455> : streams <1409721> : uri <1887181> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:100779 Archived-At: > He could break the attribute onto a new line and it would be indented like > so: > attribute="value"> > But sgml-basic-offset defaults to 2, not 3, so it doesn't make much sense > that > the attribute is indented by 3 spaces. As is clear from the code you're changing the "1+" is quite deliberate, which shows some people prefer it that way. So as discussed, this indentation step should have its own custom var. You can make it default to the behavior you prefer if you want. Other than that, the patch looks OK. Stefan