unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Drew Adams <drew.adams@oracle.com>
Cc: 32799@debbugs.gnu.org
Subject: bug#32799: 26; `(mouse-)tear-off-window'
Date: Sat, 22 Sep 2018 15:12:10 -0400	[thread overview]
Message-ID: <jwvd0t58hzy.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <c2ee91ad-2c3e-4a49-b167-e44d1068b508@default> (Drew Adams's message of "Sat, 22 Sep 2018 08:56:44 -0700 (PDT)")

> Evaluate (global-set-key "\C-o" 'tear-off-window), then try C-o.
> I get this error:
>
> command-execute: tear-off-window must be bound to an event with parameters

Fixed with the patch below,


        Stefan


diff --git a/lisp/mouse.el b/lisp/mouse.el
index 0fe4932085..d3c953e68e 100644
--- a/lisp/mouse.el
+++ b/lisp/mouse.el
@@ -333,7 +333,7 @@ mouse-select-window
 (define-obsolete-function-alias 'mouse-tear-off-window 'tear-off-window "24.4")
 (defun tear-off-window (click)
   "Delete the selected window, and create a new frame displaying its buffer."
-  (interactive "e")
+  (interactive (list last-nonmenu-event))
   (mouse-minibuffer-check click)
   (let* ((window (posn-window (event-start click)))
 	 (buf (window-buffer window))





  reply	other threads:[~2018-09-22 19:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <<9dce52eb-7982-4c75-9c7c-c06e8f69dd52@default>
     [not found] ` <<83fty1ddmh.fsf@gnu.org>
2018-09-22 15:56   ` bug#32799: 26; `(mouse-)tear-off-window' Drew Adams
2018-09-22 19:12     ` Stefan Monnier [this message]
2018-09-22 22:47       ` Drew Adams
2018-09-23  5:59         ` Eli Zaretskii
2020-08-21 11:41       ` Stefan Kangas
     [not found]   ` <<c2ee91ad-2c3e-4a49-b167-e44d1068b508@default>
     [not found]     ` <<jwvd0t58hzy.fsf-monnier+emacsbugs@gnu.org>
     [not found]       ` <<ada9f7a9-44d8-44e2-aed3-856269a7f0b3@default>
     [not found]         ` <<834legda9u.fsf@gnu.org>
2018-09-23 15:32           ` Drew Adams
2018-09-21 21:06 Drew Adams
2018-09-22 10:34 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvd0t58hzy.fsf-monnier+emacsbugs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=32799@debbugs.gnu.org \
    --cc=drew.adams@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).