From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#6581: 24.0.50; `equal-including-properties' uses `eq' to compare property values Date: Thu, 21 Oct 2021 09:06:52 -0400 Message-ID: References: <4C348D05.9000601@fastmail.net> <86bnm3igle.fsf@yandex.ru> <54B53D6B.5050903@yandex.ru> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29804"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 6581@debbugs.gnu.org, Christian Ohler , Dmitry Gutov To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 21 15:08:15 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mdXnq-0007bZ-S9 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 21 Oct 2021 15:08:15 +0200 Original-Received: from localhost ([::1]:46796 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mdXnp-0002M1-QR for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 21 Oct 2021 09:08:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38740) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mdXne-0002Jf-WF for bug-gnu-emacs@gnu.org; Thu, 21 Oct 2021 09:08:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44943) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mdXne-0004UL-OB for bug-gnu-emacs@gnu.org; Thu, 21 Oct 2021 09:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mdXne-0008Ht-JT for bug-gnu-emacs@gnu.org; Thu, 21 Oct 2021 09:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Oct 2021 13:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6581 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed patch easy Original-Received: via spool by 6581-submit@debbugs.gnu.org id=B6581.163482162731743 (code B ref 6581); Thu, 21 Oct 2021 13:08:02 +0000 Original-Received: (at 6581) by debbugs.gnu.org; 21 Oct 2021 13:07:07 +0000 Original-Received: from localhost ([127.0.0.1]:56484 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mdXml-0008Fv-4y for submit@debbugs.gnu.org; Thu, 21 Oct 2021 09:07:07 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:57538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mdXme-0008FK-R0 for 6581@debbugs.gnu.org; Thu, 21 Oct 2021 09:07:05 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id DB6171003B4; Thu, 21 Oct 2021 09:06:54 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 5B1FB100321; Thu, 21 Oct 2021 09:06:53 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1634821613; bh=iudFuB7eYEgS5jUEWW1vBYela23Oxltoee3S0yMm8Zk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=BAZWWMN6sP5nzpTbJT+cOgVqQ1p1y0ZEoYKtNc69MuNkS6d2/GcZVtMDYBtepWcQ3 wXz8SKqF7kKA7P+CLTZNhzxNQAv+MlmmS+HgYvJQsSQpExBUyijorDK9ez0bjfdpMW +Ea4fY/Y3UYDnlKKly7CGSfow1+g4bX1TBO8dmRNs6UsFNfNG5bDfpXN9rCFr3yJ9f 6mmF8UrWvWdNUKDTd+CmK9W4aDsurG/pQrUSA4ysjTT26t6TDtBFBX4CbvqiVtyfwd lYoKlW0lzZKyZuTU1nmZL8pR61Mkeap7t0Nlt+6iHqNlm0Ks+kMSFZpE+jOVMFLHn7 rvrDGssaAxoxw== Original-Received: from pastel (unknown [45.72.241.23]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 19E26120314; Thu, 21 Oct 2021 09:06:53 -0400 (EDT) In-Reply-To: (Stefan Kangas's message of "Wed, 20 Oct 2021 07:49:59 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217767 Archived-At: > The attached patch should fix it. The patch looks OK tho I can't see why you add `intervals_equal_1` to intervals.h (instead of marking it static). > (compare_string_intervals): Call intervals_equal1 with third > argument as true. Rather than paraphrase the code change this could say what's the intended effect of passing that arg. Stefan