unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: 6581@debbugs.gnu.org, Christian Ohler <ohler+emacs@fastmail.net>,
	Dmitry Gutov <dgutov@yandex.ru>
Subject: bug#6581: 24.0.50; `equal-including-properties' uses `eq' to compare property values
Date: Thu, 21 Oct 2021 09:06:52 -0400	[thread overview]
Message-ID: <jwvczny1qbq.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CADwFkmk0CBmk8J28nurivRwT3OgKJ25P8ARXVQ5+PBtOgHhEyg@mail.gmail.com> (Stefan Kangas's message of "Wed, 20 Oct 2021 07:49:59 -0700")

> The attached patch should fix it.

The patch looks OK tho I can't see why you add `intervals_equal_1` to
intervals.h (instead of marking it static).

> (compare_string_intervals): Call intervals_equal1 with third
> argument as true.

Rather than paraphrase the code change this could say what's the
intended effect of passing that arg.


        Stefan






  reply	other threads:[~2021-10-21 13:06 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-07 14:19 bug#6581: 24.0.50; `equal-including-properties' uses `eq' to compare property values Christian Ohler
2015-01-13  2:01 ` Dmitry Gutov
2015-01-13  2:23   ` Drew Adams
2015-01-13  2:27     ` Dmitry Gutov
2015-01-13 15:23   ` Stefan Monnier
2015-01-13 15:33     ` Drew Adams
2015-01-13 15:44     ` Dmitry Gutov
2015-01-13 19:53       ` Stefan Monnier
2021-10-20 14:49         ` Stefan Kangas
2021-10-21 13:06           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2021-10-21 18:05             ` Stefan Kangas
2021-10-21 18:15               ` Eli Zaretskii
2021-10-21 18:36                 ` Stefan Kangas
2021-10-31  2:25                 ` Stefan Kangas
2021-10-21 19:42               ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-21 21:02                 ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvczny1qbq.fsf-monnier+emacs@gnu.org \
    --to=bug-gnu-emacs@gnu.org \
    --cc=6581@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    --cc=monnier@iro.umontreal.ca \
    --cc=ohler+emacs@fastmail.net \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).