* bug#38024: Remove icomplete workaround [not found] <CAHyO48wYzmHL0FEc9e3peZXzHdxOSwoF4da3Qvjd2XyWvPqoMg@mail.gmail.com> @ 2021-11-01 2:38 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors 2021-11-01 3:55 ` Aaron Jensen 2021-11-01 9:28 ` Kévin Le Gouguec 0 siblings, 2 replies; 4+ messages in thread From: Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2021-11-01 2:38 UTC (permalink / raw) To: Aaron Jensen; +Cc: mail, 38024, joaotavora, kevin.legouguec Aaron Jensen [2021-10-31 20:49:23] wrote: > Originally added because of: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38024 > > The reason this fixed things was not captured and I can not reproduce > the bug with the fix disabled on master. > > This workaround has been copied to other libraries without clear > understanding of why it existed in the first place and it caused a > problem: https://github.com/minad/vertico/issues/115#issuecomment-947330581 > > Would it be possible to remove it? I'm ccing the original reporter and > fixer in case they are able to shed more light on this or test without > the fix to see if they can reproduce it. > > I've attached a patch if we are good to remove it. Thanks, I just pushed your patch to `master`. We'll see if the problem comes back, and if so, we'll have to try and fix it better. Stefan ^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#38024: Remove icomplete workaround 2021-11-01 2:38 ` bug#38024: Remove icomplete workaround Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2021-11-01 3:55 ` Aaron Jensen 2021-11-01 9:28 ` Kévin Le Gouguec 1 sibling, 0 replies; 4+ messages in thread From: Aaron Jensen @ 2021-11-01 3:55 UTC (permalink / raw) To: Stefan Monnier; +Cc: mail, 38024, joaotavora, kevin.legouguec On Sun, Oct 31, 2021 at 10:38 PM Stefan Monnier <monnier@iro.umontreal.ca> wrote: > > Aaron Jensen [2021-10-31 20:49:23] wrote: > > Originally added because of: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38024 > > > > The reason this fixed things was not captured and I can not reproduce > > the bug with the fix disabled on master. > > > > This workaround has been copied to other libraries without clear > > understanding of why it existed in the first place and it caused a > > problem: https://github.com/minad/vertico/issues/115#issuecomment-947330581 > > > > Would it be possible to remove it? I'm ccing the original reporter and > > fixer in case they are able to shed more light on this or test without > > the fix to see if they can reproduce it. > > > > I've attached a patch if we are good to remove it. > > Thanks, I just pushed your patch to `master`. > We'll see if the problem comes back, and if so, we'll have to try and > fix it better. Great, thank you! ^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#38024: Remove icomplete workaround 2021-11-01 2:38 ` bug#38024: Remove icomplete workaround Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors 2021-11-01 3:55 ` Aaron Jensen @ 2021-11-01 9:28 ` Kévin Le Gouguec 2021-11-01 15:33 ` Aaron Jensen 1 sibling, 1 reply; 4+ messages in thread From: Kévin Le Gouguec @ 2021-11-01 9:28 UTC (permalink / raw) To: Stefan Monnier; +Cc: mail, 38024, joaotavora, Aaron Jensen Hey Aaron, Stefan Monnier <monnier@iro.umontreal.ca> writes: > Aaron Jensen [2021-10-31 20:49:23] wrote: >> >> Would it be possible to remove it? I'm ccing the original reporter and >> fixer in case they are able to shed more light on this or test without >> the fix to see if they can reproduce it. >> >> I've attached a patch if we are good to remove it. > > Thanks, I just pushed your patch to `master`. > We'll see if the problem comes back, and if so, we'll have to try and > fix it better. Congrats on your investigation work; I wish I could shed more light on what this workaround was meant to accomplish. I've tried to reproduce my original issue, but so far I was not successful. If my initial report can be trusted, the bug happened (1) back when the development branch was 27.0.50 (commit 61fb521481) (2) on an old battered laptop that I can no longer power on without disturbing loud fan demons. 26.3 no longer compiles on my end[1], so all I could do was try to reproduce on master, where the workaround has been reverted, on other computers I have lying around. The symptoms have not resurfaced yet, so… I'll go with a timid, yet hopeful "yay" 🙂 [1] With gcc 11.2.1: sysdep.c:1795:22: error: variably modified ‘sigsegv_stack’ at file scope 1795 | static unsigned char sigsegv_stack[SIGSTKSZ]; | ^~~~~~~~~~~~~ ^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#38024: Remove icomplete workaround 2021-11-01 9:28 ` Kévin Le Gouguec @ 2021-11-01 15:33 ` Aaron Jensen 0 siblings, 0 replies; 4+ messages in thread From: Aaron Jensen @ 2021-11-01 15:33 UTC (permalink / raw) To: Kévin Le Gouguec; +Cc: mail, 38024, Stefan Monnier, joaotavora On Mon, Nov 1, 2021 at 5:28 AM Kévin Le Gouguec <kevin.legouguec@gmail.com> wrote: > > Hey Aaron, > > Stefan Monnier <monnier@iro.umontreal.ca> writes: > > > Aaron Jensen [2021-10-31 20:49:23] wrote: > >> > >> Would it be possible to remove it? I'm ccing the original reporter and > >> fixer in case they are able to shed more light on this or test without > >> the fix to see if they can reproduce it. > >> > >> I've attached a patch if we are good to remove it. > > > > Thanks, I just pushed your patch to `master`. > > We'll see if the problem comes back, and if so, we'll have to try and > > fix it better. > > Congrats on your investigation work; I wish I could shed more light on > what this workaround was meant to accomplish. I've tried to reproduce > my original issue, but so far I was not successful. > > If my initial report can be trusted, the bug happened (1) back when the > development branch was 27.0.50 (commit 61fb521481) (2) on an old > battered laptop that I can no longer power on without disturbing loud > fan demons. > > 26.3 no longer compiles on my end[1], so all I could do was try to > reproduce on master, where the workaround has been reverted, on other > computers I have lying around. The symptoms have not resurfaced yet, > so… I'll go with a timid, yet hopeful "yay" 🙂 Thank you for confirming. Hopefully that's the last of it! Best, Aaron ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-11-01 15:33 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- [not found] <CAHyO48wYzmHL0FEc9e3peZXzHdxOSwoF4da3Qvjd2XyWvPqoMg@mail.gmail.com> 2021-11-01 2:38 ` bug#38024: Remove icomplete workaround Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors 2021-11-01 3:55 ` Aaron Jensen 2021-11-01 9:28 ` Kévin Le Gouguec 2021-11-01 15:33 ` Aaron Jensen
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).