From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#53227: master: Wrong error message with M-: (funcall). Date: Thu, 13 Jan 2022 15:37:10 -0500 Message-ID: References: <874k683smu.fsf@gmail.com> <87mtk0ugjn.fsf@gnus.org> <87pmov52gx.fsf@igel.home> <87fspr4pga.fsf@igel.home> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16263"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 53227@debbugs.gnu.org, acm@muc.de, larsi@gnus.org, rpluim@gmail.com To: Andreas Schwab Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 13 21:48:49 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n871c-00044s-UI for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Jan 2022 21:48:49 +0100 Original-Received: from localhost ([::1]:41712 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n871b-0005N9-Kv for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Jan 2022 15:48:47 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:49114) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n86rC-0003kv-VA for bug-gnu-emacs@gnu.org; Thu, 13 Jan 2022 15:38:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41789) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n86rC-0006nG-KY for bug-gnu-emacs@gnu.org; Thu, 13 Jan 2022 15:38:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n86rC-0001wj-EN for bug-gnu-emacs@gnu.org; Thu, 13 Jan 2022 15:38:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Jan 2022 20:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53227 X-GNU-PR-Package: emacs Original-Received: via spool by 53227-submit@debbugs.gnu.org id=B53227.16421062427421 (code B ref 53227); Thu, 13 Jan 2022 20:38:02 +0000 Original-Received: (at 53227) by debbugs.gnu.org; 13 Jan 2022 20:37:22 +0000 Original-Received: from localhost ([127.0.0.1]:34692 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n86qX-0001vb-Tw for submit@debbugs.gnu.org; Thu, 13 Jan 2022 15:37:22 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:44892) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n86qV-0001vK-Jm for 53227@debbugs.gnu.org; Thu, 13 Jan 2022 15:37:20 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 8BFE34423A7; Thu, 13 Jan 2022 15:37:13 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id E847D44239C; Thu, 13 Jan 2022 15:37:11 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1642106231; bh=IurxfF6TDQ9trRyDDO2FfkyeP+UgYwW98zrH4IO8ayY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=OOE/rLI5RklizprF0UxnFVkPTBMs98NkkmAGEL2pAJdkEhfvpaZziJm0EKelMLSLq ZNvhPmJgEbbfiaYfxTHdQ0vPklzOa7Chw7ZbB76T8/cuvsW0Z6L9t7tFFGJ4BwrfyE L6U05eyOxJ5GXoJicnOgQgTSEI7S60QLf2p/GDSUUjjJUcl2dO/gnIpPrkn0mlX+vN KUAXoEdMciHAzNlH7sK5lCHipaSspOFzjKHMhNkNbfIIZRmW7oY1Qve/xaQldWv+Ib 7ZYkWuSwt0gES2rl28I0kARd4ZOAKCtWUO55bAHNHU+8MuHs8n+tc5+kI4GrM6MskM GYjeWJ2/VBtrg== Original-Received: from ceviche (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A3EC61204D4; Thu, 13 Jan 2022 15:37:11 -0500 (EST) In-Reply-To: <87fspr4pga.fsf@igel.home> (Andreas Schwab's message of "Thu, 13 Jan 2022 16:37:09 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:224135 Archived-At: Andreas Schwab [2022-01-13 16:37:09] wrote: > On Jan 13 2022, Stefan Monnier via "Bug reports for GNU Emacs, the Swiss > army knife of text editors" wrote: >>> Same as bug #46636. >> Actually, it's a different bug, tho its origin might be the same commit. > It's coming from the same funcall rewrite rule. I see you agree ;-) The patch should hopefully fix both cases, tho as you can see the two cases are fixed separately (which is what I mean by them being two different bugs). Stefan diff --git a/lisp/emacs-lisp/macroexp.el b/lisp/emacs-lisp/macroexp.el index b44917f7d56..33ce55a3de8 100644 --- a/lisp/emacs-lisp/macroexp.el +++ b/lisp/emacs-lisp/macroexp.el @@ -366,14 +366,18 @@ macroexp--expand-all form) (macroexp--expand-all newform)))) - (`(funcall . ,(or `(,exp . ,args) pcase--dontcare)) + (`(funcall ,exp . ,args) (let ((eexp (macroexp--expand-all exp)) (eargs (macroexp--all-forms args))) ;; Rewrite (funcall #'foo bar) to (foo bar), in case `foo' ;; has a compiler-macro, or to unfold it. (pcase eexp - (`#',f (macroexp--expand-all `(,f . ,eargs))) + ((and `#',f + (guard (not (or (special-form-p f) (macrop f)))));; bug#46636 + (macroexp--expand-all `(,f . ,eargs))) (_ `(funcall ,eexp . ,eargs))))) + (`(funcall . ,_) form) ;bug#53227 + (`(,func . ,_) (let ((handler (function-get func 'compiler-macro)) (funargs (function-get func 'funarg-positions)))