From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead) Date: Wed, 26 Jan 2022 08:36:34 -0500 Message-ID: References: <868u41rv84.fsf@yandex.ru> <83fuy8p8oq.fsf@gnu.org> <568FA9D0.2040609@yandex.ru> <83egdsp88n.fsf@gnu.org> <568FABFC.3000205@yandex.ru> <87tufr74of.fsf@gnus.org> <87lf0yjwpw.fsf@gnus.org> <87r1aodus0.fsf@gnus.org> <66aa873d-5f5f-9024-efb6-e6110c27ab3a@yandex.ru> <87ilvy4m94.fsf@gnus.org> <87czklnqvs.fsf@gnus.org> <3045ca8b-f5d6-c85e-d170-3fe158fec64e@yandex.ru> <87ilu94gac.fsf@gnus.org> <43725c9f-1f0a-fb43-82a2-3f284791fdf5@yandex.ru> <875yq8ypmi.fsf@gnus.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4945"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , 22324@debbugs.gnu.org, Dmitry Gutov To: Daniel Mendler Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 26 15:01:17 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nCirN-00015a-Kb for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 26 Jan 2022 15:01:17 +0100 Original-Received: from localhost ([::1]:46422 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nCirM-0000wn-MB for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 26 Jan 2022 09:01:16 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58800) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nCiUa-00085w-4c for bug-gnu-emacs@gnu.org; Wed, 26 Jan 2022 08:37:46 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58345) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nCiTu-00079G-DD for bug-gnu-emacs@gnu.org; Wed, 26 Jan 2022 08:37:35 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nCiTu-0005OA-5V for bug-gnu-emacs@gnu.org; Wed, 26 Jan 2022 08:37:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Jan 2022 13:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22324 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 22324-submit@debbugs.gnu.org id=B22324.164320420720689 (code B ref 22324); Wed, 26 Jan 2022 13:37:02 +0000 Original-Received: (at 22324) by debbugs.gnu.org; 26 Jan 2022 13:36:47 +0000 Original-Received: from localhost ([127.0.0.1]:51248 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCiTe-0005Nd-O7 for submit@debbugs.gnu.org; Wed, 26 Jan 2022 08:36:46 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:46444) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCiTc-0005NO-5h for 22324@debbugs.gnu.org; Wed, 26 Jan 2022 08:36:45 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 1000244293D; Wed, 26 Jan 2022 08:36:38 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 7C86C44293B; Wed, 26 Jan 2022 08:36:36 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1643204196; bh=8L5iSPBUvZ/goaDTgWIF4Wc+VMEE9YRLCbbE5B1P7Xk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=MgIlWhq8suomF2K5ExvlATBMqSmv83sr95Ujv80g2hrBPm8YgfzHgSUNGSg8jEyT8 rErwGIw33xfjvYlvARMVFmalNMLYk2+GL1yQ2zMkOxekfzrIWdV9+1mlAXZLLwwlkK FdZRUJwO1WVh4vE6STOQQGMPcYRw/tOEJoU1pdPr5BJgNLlFaeH3zrfKjn8jtjeL15 EzmghsvGJp2bBcc5yZ/QqEXbOwvNxFFA828o7rGtts/G1U4pi9gBKTj6pZE8P2+nou zAPyNr+Vejx4KxCbx5BzDi/YZejv3pDMgI4n3DbArIybimpFaCD9SQq3Q/iYpaiDqr 7Qujiw+TALHTg== Original-Received: from ceviche (76-10-138-212.dsl.teksavvy.com [76.10.138.212]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 4A763120648; Wed, 26 Jan 2022 08:36:36 -0500 (EST) In-Reply-To: (Daniel Mendler's message of "Wed, 26 Jan 2022 03:31:08 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:225259 Archived-At: >> Apparently this config is recommended in the README of both Corfu and >> Vertico (https://github.com/minad/vertico#configuration), both projects >> by Daniel Mendler. >> I guess we should ask Daniel whether he has been aware of the >> completion-styles failover mechanic, and what he thinks about it. > Yes, I've been aware of the failover mechanic and I think it is not > good. From my experience, I would prefer if the override is a real > override, which this issue is about. Users can still opt-in to the > default styles on a case by case basis if this is desired. We can probably have our cake and eat it too by adding a `fail` completion style. Such a style would always take responsibility (i.e. would never return nil to delegate to subsequent styles), but would always return a "useless" value that gives no completions. Then entries in `completion-category-override/defaults` could choose to either be mere additions to the global default (as now) or be a full override (which they'd get by having this `fail` style at the end). > Furthermore we've also got `completion-category-defaults`. It may make > sense to distinguish them by making the override a real override and > keep the current behavior for the defaults. No, the role of those two is already quite different: `completion-category-defaults` is for packages to set, whereas `completion-category-override` is to be set by end-users. Stefan