From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#56305: 29.0.50; 'yes-or-no-p' deselects minibuffer frame Date: Wed, 06 Jul 2022 14:34:39 -0400 Message-ID: References: <83bku69nn2.fsf@gnu.org> <83iloc8yzs.fsf@gnu.org> <83h73w8f7i.fsf@gnu.org> <83zghn7ckd.fsf@gnu.org> <83zghm5evt.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14766"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: rudalics@gmx.at, Eli Zaretskii , 56305@debbugs.gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 06 20:35:18 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o99rp-0003Wh-Sk for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Jul 2022 20:35:18 +0200 Original-Received: from localhost ([::1]:42478 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o99ro-0003oO-MS for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Jul 2022 14:35:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43404) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o99ra-0003nx-4Y for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2022 14:35:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33025) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o99rZ-0006tK-S8 for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2022 14:35:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o99rZ-0000dH-QC for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2022 14:35:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Jul 2022 18:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56305 X-GNU-PR-Package: emacs Original-Received: via spool by 56305-submit@debbugs.gnu.org id=B56305.16571324902410 (code B ref 56305); Wed, 06 Jul 2022 18:35:01 +0000 Original-Received: (at 56305) by debbugs.gnu.org; 6 Jul 2022 18:34:50 +0000 Original-Received: from localhost ([127.0.0.1]:55155 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o99rN-0000co-Ou for submit@debbugs.gnu.org; Wed, 06 Jul 2022 14:34:49 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:49732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o99rM-0000cZ-0p for 56305@debbugs.gnu.org; Wed, 06 Jul 2022 14:34:48 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 541744424AC; Wed, 6 Jul 2022 14:34:42 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id F24874424A5; Wed, 6 Jul 2022 14:34:40 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1657132480; bh=HN7WTE1lTY/LahaXLFJm1jeDztfJpc64ucpM+7vh2YM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=TI1cnAqqvAzI38P5Q6LDOYAOlbc1h1bylMyA2LONXyuHvAZDThMOgnUxKrstXB7So kSzJni8kuEJN+u/95XHEzSeQRy5mgqx2qB9u4WhC0S0LzYeZrpTBOtwjcX2FoFhX3w A2SJPxZ0Nx4JKHimiqnYNKQsKb0BQ1UsJVqAyxJQ5241hC6pS0zPb+Vc7MLYYm3C41 XwsBiPGdkh6tswJbp6g3ATKGEnqJ0VnhGQwE6k/5097khgHJafrcjbPSpmS6a0+Rda Ty+a7lmCzkjCY2bbU/4JTaWBuELzcParzAU9eyYcQqN4XiLQ01FweuTMpFKR1TrS7Z x80Z03DBX8ilQ== Original-Received: from pastel (unknown [45.72.196.165]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id BDCCE1202DB; Wed, 6 Jul 2022 14:34:40 -0400 (EDT) In-Reply-To: (Alan Mackenzie's message of "Wed, 6 Jul 2022 18:16:03 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:236288 Archived-At: >> > > Do you have a suggestion for a change there to improve the behavior? >> > I do now. I think we should expunge the entire section of code. FWIW, I totally agree. I'm far from sure that the result will be what we want, but I think that in case it's not we will then know better what it is that we want and we'll be in a better position to find a good solution. >> I guess that means Emacs 28.2 will have this issue unresolved, unless >> someone comes up with some ideas. > An idea I had on Sunday was to forcibly set the window system focus to > the minibuffer frame just before the recursive edit in read_minibuf, > though I didn't post a patch for it. This appears to work for me. Not sure if "Fx_focus_frame (mini_frame, Qt)" is The Right solution in the sense that it may fail to correctly set the accompanying redirection from the "original" frame. But it seems like a good stop-gap for `emacs-28`, yes. I'd recommend we try not to use it in `master` (where we could instead check that the mini_frame has the focus and drop into the debugger if not to try and figure out what can cause such a situation). Stefan