From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#66636: Move lexical-binding warning from checkdoc to byte-compiler Date: Fri, 20 Oct 2023 09:38:33 -0400 Message-ID: References: <48764CD1-C80F-4613-9848-BD8CA9203A40@gmail.com> <87ttql4yfq.fsf@yahoo.com> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15724"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , 66636@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 20 15:39:49 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qtpjB-0003wZ-7w for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 20 Oct 2023 15:39:49 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qtpj0-0000O8-5r; Fri, 20 Oct 2023 09:39:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtpix-0000Ns-IU for bug-gnu-emacs@gnu.org; Fri, 20 Oct 2023 09:39:35 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qtpix-0007tN-5R for bug-gnu-emacs@gnu.org; Fri, 20 Oct 2023 09:39:35 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qtpjO-0005BE-AE for bug-gnu-emacs@gnu.org; Fri, 20 Oct 2023 09:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Oct 2023 13:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66636 X-GNU-PR-Package: emacs Original-Received: via spool by 66636-submit@debbugs.gnu.org id=B66636.169780915419846 (code B ref 66636); Fri, 20 Oct 2023 13:40:02 +0000 Original-Received: (at 66636) by debbugs.gnu.org; 20 Oct 2023 13:39:14 +0000 Original-Received: from localhost ([127.0.0.1]:38967 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtpib-0005A1-Ug for submit@debbugs.gnu.org; Fri, 20 Oct 2023 09:39:14 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:47536) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtpiW-00059k-RQ for 66636@debbugs.gnu.org; Fri, 20 Oct 2023 09:39:12 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 64D1E100187; Fri, 20 Oct 2023 09:38:35 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1697809114; bh=SEEJ9sMQyCt0MXpHStOApY+8V8lP1ZPLLM0boNTczUc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Oa5waosqqfGHDCfQLjopJHwEuKzRlL93qgCIfzNjV9ohAB/ABLk0TFT13LcZiHBlp a0NRJuB+KiAel6rTelh6sDNUl8wfD/gBEgDSjdqSONQzwi90kwxptw+Tyfb/0pQCtQ nCCwThsV5V5ESmAamoYeXwILnKK5jma69Cviswnfwd6jkqKT7sJiKXzasVUgPCAJ3v XopPBFPQ+Xi/uuceRsf9LUWChNrBbdALenXQGHQiRgjbDfEU19WdPhG+hrk3c6291K +koKdLEL+W2mK13SqZGBYruutQlw5G9iUG92HO6xXdXZ8OYqwC7/Za4Ctw8sqGPWvP /OUxUDBP2Y/OQ== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 44B061000A3; Fri, 20 Oct 2023 09:38:34 -0400 (EDT) Original-Received: from pastel (unknown [45.72.216.111]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 1A9E21201BB; Fri, 20 Oct 2023 09:38:34 -0400 (EDT) In-Reply-To: <87ttql4yfq.fsf@yahoo.com> (Po Lu's message of "Fri, 20 Oct 2023 14:09:45 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:272795 Archived-At: >> The warning about a missing lexical-binding cookie rather belongs in >> the compiler than checkdoc, because it's not about documentation or >> style but code generation and ability to detect errors, both which are >> hindered by a missing cookie. >> >> Moving the warning to the compiler also makes it more widely seen. > > So long as this warning is only displayed within code part of Emacs > itself, there are no valid objections to such a change. > > But you have instead elected to generate warnings whenever such files > are byte-compiled. There exist many packages which do not enable > lexical binding, whose authors have studiously elected not to: most of > Drew Adams' for example. So this is tantamount to punitive action > against their users, in the form of an unsightly warning each time such > packages are installed. No, it's just asking those authors to make the result of their studious work explicit with -*- lexical-binding: nil -*- -- Stefan