From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#68246: 30.0.50; Add non-TS mode as extra parent of TS modes Date: Wed, 10 Jan 2024 11:11:58 -0500 Message-ID: References: <831qavvcbo.fsf@gnu.org> <5ee1a261-0d5d-4567-b98a-5f8100b55b0c@gutov.dev> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="847"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 68246@debbugs.gnu.org, Eli Zaretskii , casouri@gmail.com, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 10 17:13:25 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rNbCn-000Aaw-HK for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Jan 2024 17:13:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rNbCT-00067f-Ii; Wed, 10 Jan 2024 11:13:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNbCS-00067Q-FL for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2024 11:13:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rNbCS-0008O8-7W for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2024 11:13:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rNbCQ-0006hP-IW for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2024 11:13:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Jan 2024 16:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68246 X-GNU-PR-Package: emacs Original-Received: via spool by 68246-submit@debbugs.gnu.org id=B68246.170490318025743 (code B ref 68246); Wed, 10 Jan 2024 16:13:02 +0000 Original-Received: (at 68246) by debbugs.gnu.org; 10 Jan 2024 16:13:00 +0000 Original-Received: from localhost ([127.0.0.1]:42560 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNbCN-0006h9-Sk for submit@debbugs.gnu.org; Wed, 10 Jan 2024 11:13:00 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:24217) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNbCM-0006gv-Ak for 68246@debbugs.gnu.org; Wed, 10 Jan 2024 11:12:58 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 400FF442CC8; Wed, 10 Jan 2024 11:12:54 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1704903172; bh=xaj0IciQ4eP39zG5Sld8CW2PnLbfF8wEtzrs9D6Wk6M=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=jxfNs9GFgIxMYr2TRdQgXljwkCb+Y40nj7O+ETg0G5oYd4AHjFQ6USb/C77oqGbCr zQL6aptXa/0FSuOQXkwurWuw51VtBWY0cBmKZfDExP1oO22bLttLXvuEJjmCf550LT pjSPvCdvJAtD98GNv5ZfwvQy1jrcYuawpuNkEA+O8ZlE40J6N7iXyNfxHPjRrq2ijZ oNJ36OULBjdM1JBTQlMUhQrE7XFaGvaRj8K0W1XOpzKYIwHuppVhzJo+L6FiNBuTIj VzTM1AvJ7eu4+/J9cK6xmLDJOW22xk/Oay6pm7NceW5THoDC2/ghHydGMSvMNa7Bid kSrSSL17eoc4A== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id A6933442D88; Wed, 10 Jan 2024 11:12:52 -0500 (EST) Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 942B3120A6F; Wed, 10 Jan 2024 11:12:52 -0500 (EST) In-Reply-To: <5ee1a261-0d5d-4567-b98a-5f8100b55b0c@gutov.dev> (Dmitry Gutov's message of "Wed, 10 Jan 2024 03:18:47 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277771 Archived-At: > That's very nice and concise, but it still leaves the issue of users being > able to use a common hook for a family of major modes (for the same > language). So I guess some inheritance-based solution is needed? We have `define-derived-mode` for that. And even those major modes which don't want to inherit via `define-derived-mode` can `run-mode-hooks` any additional hook they like. Doing it when a mode is defined is easy and "safe". Changing it after the fact risks introducing breakage (just like my `derived-mode-add-parents` does) where the code run via the hook depends on specific details of the original mode which aren't available in the "pseudo-derived" mode. For this reason my patch only proposes the use of `derived-mode-add-parents` since that's the part where a clear need has been found. Stefan