From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#1046: 23.0.60; vc-dir with Subversion Date: Mon, 06 Oct 2008 10:18:45 -0400 Message-ID: References: <18655.13103.295021.779321@kahikatea.snap.net.nz> <18663.12069.154443.910505@kahikatea.snap.net.nz> Reply-To: Stefan Monnier , 1046@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1223303618 12853 80.91.229.12 (6 Oct 2008 14:33:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 6 Oct 2008 14:33:38 +0000 (UTC) Cc: 1046@emacsbugs.donarmstrong.com To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 06 16:34:34 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Kmr8U-0001AK-29 for geb-bug-gnu-emacs@m.gmane.org; Mon, 06 Oct 2008 16:32:34 +0200 Original-Received: from localhost ([127.0.0.1]:49429 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kmr7Q-0005xu-Ij for geb-bug-gnu-emacs@m.gmane.org; Mon, 06 Oct 2008 10:31:28 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Kmr63-0005JV-4E for bug-gnu-emacs@gnu.org; Mon, 06 Oct 2008 10:30:03 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Kmr61-0005IN-8r for bug-gnu-emacs@gnu.org; Mon, 06 Oct 2008 10:30:02 -0400 Original-Received: from [199.232.76.173] (port=42678 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kmr60-0005Hq-DV for bug-gnu-emacs@gnu.org; Mon, 06 Oct 2008 10:30:00 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:33829) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Kmr5z-0002V5-NJ for bug-gnu-emacs@gnu.org; Mon, 06 Oct 2008 10:30:00 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m96ETvCf014629; Mon, 6 Oct 2008 07:29:57 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m96EP4Dj013557; Mon, 6 Oct 2008 07:25:04 -0700 X-Loop: don@donarmstrong.com Resent-From: Stefan Monnier Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 06 Oct 2008 14:25:03 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1046 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: patch Original-Received: via spool by 1046-submit@emacsbugs.donarmstrong.com id=B1046.122330273212221 (code B ref 1046); Mon, 06 Oct 2008 14:25:03 +0000 Original-Received: (at 1046) by emacsbugs.donarmstrong.com; 6 Oct 2008 14:18:52 +0000 Original-Received: from chene.dit.umontreal.ca (chene.dit.umontreal.ca [132.204.246.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m96EImSb012215 for <1046@emacsbugs.donarmstrong.com>; Mon, 6 Oct 2008 07:18:49 -0700 Original-Received: from alfajor.home (vpn-132-204-232-40.acd.umontreal.ca [132.204.232.40]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id m96EIj6e017385; Mon, 6 Oct 2008 10:18:45 -0400 Original-Received: by alfajor.home (Postfix, from userid 20848) id 6780F1C3E8; Mon, 6 Oct 2008 10:18:45 -0400 (EDT) In-Reply-To: (Glenn Morris's message of "Sat, 04 Oct 2008 15:54:00 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3118=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Mon, 06 Oct 2008 10:30:02 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:21171 Archived-At: >> (let (result dirlist) > [...] >> (let ((basename (match-string 1)) >> (file (expand-file-name basename dir)) >> (status (or (vc-file-getprop file 'vc-state) >> (vc-cvs-parse-entry file t)))) > My personal preference is to use as few lets as possible (in case we > start running out...). We still have a large supply of `let's, so you can use them liberally. Especially if they can eliminate a few pesky `setq's. They only problem with `let's as of now is that they eat up indentation space, but it's rarely a serious problem. Stefan