From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#3973: cleanup view-mode usage in vc-resynch-window Date: Thu, 30 Jul 2009 23:43:39 -0400 Message-ID: References: <200907300744.n6U7iwdl028160@godzilla.ics.uci.edu> <200907302206.n6UM6pBR008840@godzilla.ics.uci.edu> <200907310322.n6V3Mo26012548@godzilla.ics.uci.edu> Reply-To: Stefan Monnier , 3973@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1249013241 27691 80.91.229.12 (31 Jul 2009 04:07:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 31 Jul 2009 04:07:21 +0000 (UTC) Cc: 3973@emacsbugs.donarmstrong.com To: Dan Nicolaescu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 31 06:07:13 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MWjOg-0007fE-HH for geb-bug-gnu-emacs@m.gmane.org; Fri, 31 Jul 2009 06:07:10 +0200 Original-Received: from localhost ([127.0.0.1]:59144 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MWjOg-0005qv-18 for geb-bug-gnu-emacs@m.gmane.org; Fri, 31 Jul 2009 00:07:10 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MWjOO-0005ma-Lp for bug-gnu-emacs@gnu.org; Fri, 31 Jul 2009 00:06:52 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MWjOJ-0005m4-Gz for bug-gnu-emacs@gnu.org; Fri, 31 Jul 2009 00:06:51 -0400 Original-Received: from [199.232.76.173] (port=60696 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MWjOJ-0005m0-E4 for bug-gnu-emacs@gnu.org; Fri, 31 Jul 2009 00:06:47 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:40974) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MWjOJ-0000Sg-3n for bug-gnu-emacs@gnu.org; Fri, 31 Jul 2009 00:06:47 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n6V46iS5007348; Thu, 30 Jul 2009 21:06:45 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n6V3o5F2005002; Thu, 30 Jul 2009 20:50:05 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Stefan Monnier Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Fri, 31 Jul 2009 03:50:05 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 3973 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 3973-submit@emacsbugs.donarmstrong.com id=B3973.12490118304463 (code B ref 3973); Fri, 31 Jul 2009 03:50:05 +0000 Original-Received: (at 3973) by emacsbugs.donarmstrong.com; 31 Jul 2009 03:43:50 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from ironport2-out.teksavvy.com (ironport2-out.pppoe.ca [206.248.154.182]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n6V3hjv6004458 for <3973@emacsbugs.donarmstrong.com>; Thu, 30 Jul 2009 20:43:47 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvoEAOcEckpFpZgv/2dsb2JhbACBUtEWhBcFhxqCUQ X-IronPort-AV: E=Sophos;i="4.43,299,1246852800"; d="scan'208";a="42601016" Original-Received: from 69-165-152-47.dsl.teksavvy.com (HELO pastel.home) ([69.165.152.47]) by ironport2-out.teksavvy.com with ESMTP; 30 Jul 2009 23:43:39 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 79978800B; Thu, 30 Jul 2009 23:43:39 -0400 (EDT) In-Reply-To: <200907310322.n6V3Mo26012548@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Thu, 30 Jul 2009 20:22:50 -0700 (PDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Fri, 31 Jul 2009 00:06:51 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:29754 Archived-At: >> > I have removed that code locally for a while and didn't see any >> > problem. But I don't explicitly use view-mode, so... >> >> Obiously the code only makes a difference when you use view-read-only, >> so you'll need to set it to a non-nil value before doing any test. > [I've never done anything with view-read-only before...] > I set view-read-only to t, then played with a file under RCS. > When the files is checked in view-mode is turned on, when checking it > out it's turned off. > If the code in question is eliminated, view-mode stays turned on after > checking out. > There's some code in `after-find-file' (that gets called from > `revert-buffer') that looks like it does something very similar to the > code in question here, but `after-find-file' is called with `nomodes' t, > so that code does not trigger. So it seems the code is still needed. Maybe we could/should replace it with something more clear: E.g. move that code to a new function `view-refresh' (or whatever else), which we can then call from VC. Maybe a better option in the longer term is refine the meaning of the `preserve-modes' arg to revert-buffer, so that some minor modes can request to be refreshed or not (the VC state is one that would also benefit from such a change, as can be seen in auto-revert-mode). Stefan