From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#3274: ido-completing-read doesn't work unless ido-mode is executed Date: Sun, 28 Nov 2010 15:50:19 -0500 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1290978913 5413 80.91.229.12 (28 Nov 2010 21:15:13 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 28 Nov 2010 21:15:13 +0000 (UTC) Cc: 3274@debbugs.gnu.org, Daniel Colascione To: Leo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 28 22:15:08 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PMoaO-0004P3-Fr for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Nov 2010 22:15:04 +0100 Original-Received: from localhost ([127.0.0.1]:55696 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PMoaN-0002EM-Rn for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Nov 2010 16:15:03 -0500 Original-Received: from [140.186.70.92] (port=53514 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PMoaH-0002Dc-KY for bug-gnu-emacs@gnu.org; Sun, 28 Nov 2010 16:14:58 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PMoaG-0007OX-Cd for bug-gnu-emacs@gnu.org; Sun, 28 Nov 2010 16:14:57 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35786) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PMoaG-0007OT-B2 for bug-gnu-emacs@gnu.org; Sun, 28 Nov 2010 16:14:56 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PMo7K-0007Hf-Bb; Sun, 28 Nov 2010 15:45:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Nov 2010 20:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 3274 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 3274-submit@debbugs.gnu.org id=B3274.129097709227972 (code B ref 3274); Sun, 28 Nov 2010 20:45:02 +0000 Original-Received: (at 3274) by debbugs.gnu.org; 28 Nov 2010 20:44:52 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PMo7A-0007H7-B1 for submit@debbugs.gnu.org; Sun, 28 Nov 2010 15:44:52 -0500 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PMo78-0007Gv-8V for 3274@debbugs.gnu.org; Sun, 28 Nov 2010 15:44:50 -0500 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id oASKoJ0e029921; Sun, 28 Nov 2010 15:50:20 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 7DE6AA85F1; Sun, 28 Nov 2010 15:50:19 -0500 (EST) In-Reply-To: (Leo's message of "Sun, 28 Nov 2010 13:53:26 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3693=0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sun, 28 Nov 2010 15:45:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:41984 Archived-At: >> I also ran into this bug a while back but didn't stop to fix it. >> Could you verify the following patch fixes the bug? > --- a/lisp/ido.el > +++ b/lisp/ido.el > @@ -4853,6 +4853,9 @@ DEF, if non-nil, is the default value." > (ido-directory-too-big nil) > (ido-context-switch-command 'ignore) > (ido-choice-list choices)) > + ;; Initialize ido before invoking ido-read-internal > + (unless (keymapp ido-common-completion-map) > + (let (ido-mode) (ido-mode 1))) > (ido-read-internal 'list prompt hist def require-match initial-input))) "(let (ido-mode) (ido-mode 1))" is an "ugly hack" (not only because it calls (ido-mode 1) but because of the let-binding). > Please consider this patch instead. While the previous fix is minimal it > does a bit too much by calling (ido-mode 1). Glad you found a better solution. Your patch looks good. Savannah is down right now, so I'll install it later. Thanks. Stefan