* [PATCH] Add Microsoft support to cc-mode @ 2010-08-31 21:01 Daniel Colascione 2010-09-01 6:38 ` bug#6959: " Stefan Monnier ` (3 more replies) 0 siblings, 4 replies; 6+ messages in thread From: Daniel Colascione @ 2010-08-31 21:01 UTC (permalink / raw) To: emacs-devel, bug-gnu-emacs Microsoft uses a... unique programming style (erm, typedef void VOID?!) that tends to trip up cc-mode. Particularly problematic are certain code annotations, as described in http://msdn.microsoft.com/en-us/library/aa383701(VS.85).aspx. This patch adds support for this bizarre programming style and allows one to work on idiomatic Windows sources comfortably. You can get the diff at http://bazaar.launchpad.net/~dan-colascione/emacs/c++0x/revision/101039 ^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#6959: [PATCH] Add Microsoft support to cc-mode 2010-08-31 21:01 [PATCH] Add Microsoft support to cc-mode Daniel Colascione @ 2010-09-01 6:38 ` Stefan Monnier [not found] ` <jwvoccic73r.fsf-monnier+emacs@gnu.org> ` (2 subsequent siblings) 3 siblings, 0 replies; 6+ messages in thread From: Stefan Monnier @ 2010-09-01 6:38 UTC (permalink / raw) To: Daniel Colascione; +Cc: 6959 [ Please don't send to both emacs-devel and bug-gnu-emacs, otherwise every reply in emacs-devel risks generating a new bug-number. ] > Microsoft uses a... unique programming style (erm, typedef void > VOID?!) that tends to trip up cc-mode. What do you mean by "trip up"? Sounds like a plain bug to me: any normal program may have such definitions (tho it depends on how "tripped up" it gets; it's normal for cc-mode to behave suboptimally when encountering unknown macros and type annotations, but it should try to be robust in such circumstances). > Particularly problematic are certain code annotations, as described in > http://msdn.microsoft.com/en-us/library/aa383701(VS.85).aspx. This > patch adds support for this bizarre programming style and allows one > to work on idiomatic Windows sources comfortably. Similar needs arise for large projects (e.g. DEFUN and friends in Emacs's C code), IIUC, right? So I think we would want to move such project/system-specific outside cc-langs.el so users can (load "cc-microsoft") or (load "cc-linux") or (load "cc-emacs"). Tho, loading a file is the wrong interface, so maybe it can live in cc-langs.el but it should be inside a function so you could activate it with (cc-enable-microsoft-keywords), or maybe a minor mode (cc-microsoft-keywords-mode 1), tho turning it off might not be that important. The point is to make it modular so it's easy for people to add support for particular projects. Stefan ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <jwvoccic73r.fsf-monnier+emacs@gnu.org>]
* bug#6959: [PATCH] Add Microsoft support to cc-mode [not found] ` <jwvoccic73r.fsf-monnier+emacs@gnu.org> @ 2011-01-14 5:54 ` Daniel Colascione 2011-01-14 15:52 ` Stefan Monnier 0 siblings, 1 reply; 6+ messages in thread From: Daniel Colascione @ 2011-01-14 5:54 UTC (permalink / raw) To: Stefan Monnier; +Cc: 6959 Hi Stefan, On Tue, Aug 31, 2010 at 11:38 PM, Stefan Monnier <monnier@iro.umontreal.ca> wrote: > So I think we would want to move such project/system-specific outside > cc-langs.el so users can (load "cc-microsoft") or (load "cc-linux") or > (load "cc-emacs"). Tho, loading a file is the wrong interface, so maybe > it can live in cc-langs.el but it should be inside a function so you > could activate it with (cc-enable-microsoft-keywords), or maybe a minor > mode (cc-microsoft-keywords-mode 1), tho turning it off might not be > that important. > The point is to make it modular so it's easy for people to add support > for particular projects. Unfortunately, cc-mode doesn't have a good mechanism for implementing the kind of interface we'd both like. To do it, we have essentially two choices: 1) Define a new, external cc-mode language for each optional package: he problem with this approach is that the language structure is a tree, so you can't easily combine multiple optional packages. Besides, cc-engine.el and cc-fonts.el have many explicit tests for specific languages (especially C++), and defining a language derived from C++ will make these tests fail. This is a separate bug, and one reason very few people actually use the cc-mode external language support. 2) Allow c-lang-defconst values to be redefined by the user after cc-mode is compiled: this would work fine, and would permit exactly the kind of interface you propose. The main problem is that c-lang-defconst values are baked into modes and their font-lock-keywords values at compile time,though there's a special case for c-extra-types. Fixing this deficiency would require the entire cc-mode variable graph to be evaluated at mode initialization time. On a modern machine, that shouldn't be a performance problem, but the current macrology is subtle and quick to anger. I'm also not quite sure what should happen when, for a variable c-foo, we have a c-mode definition, a c++-mode definition that relies on the c-mode value, and the user customizes the value for c-foo in c-mode. Do we need to re-evaluate the value for c++-mode? Integrating major language extensions directly into cc-mode is the least general, but also the least invasive solution to the problem, and there's already some precedent for QT. Until we get that generic user-customizable, composable PEG-based mode support I've been dreaming about, it's the best we can do. I've just been using a private branch for cc-mode, but that's not an option for sane people. :-) Regards, Daniel Colascione ^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#6959: [PATCH] Add Microsoft support to cc-mode 2011-01-14 5:54 ` Daniel Colascione @ 2011-01-14 15:52 ` Stefan Monnier 0 siblings, 0 replies; 6+ messages in thread From: Stefan Monnier @ 2011-01-14 15:52 UTC (permalink / raw) To: Daniel Colascione; +Cc: 6959 > I've just been using a private branch for cc-mode, but that's not an > option for sane people. :-) Hopefully by now, none of our users are still sane, Stefan ^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#6959: [PATCH] Add Microsoft support to cc-mode 2010-08-31 21:01 [PATCH] Add Microsoft support to cc-mode Daniel Colascione 2010-09-01 6:38 ` bug#6959: " Stefan Monnier [not found] ` <jwvoccic73r.fsf-monnier+emacs@gnu.org> @ 2016-02-26 6:42 ` Lars Ingebrigtsen [not found] ` <87r3g0t1jx.fsf@gnus.org> 3 siblings, 0 replies; 6+ messages in thread From: Lars Ingebrigtsen @ 2016-02-26 6:42 UTC (permalink / raw) To: Daniel Colascione; +Cc: 6959, emacs-devel Daniel Colascione <dan.colascione@gmail.com> writes: > Microsoft uses a... unique programming style (erm, typedef void > VOID?!) that tends to trip up cc-mode. Particularly problematic are > certain code annotations, as described in > http://msdn.microsoft.com/en-us/library/aa383701(VS.85).aspx. This > patch adds support for this bizarre programming style and allows one > to work on idiomatic Windows sources comfortably. > > You can get the diff at > > http://bazaar.launchpad.net/~dan-colascione/emacs/c++0x/revision/101039 Could you resend the patch (if this is still an issue)? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <87r3g0t1jx.fsf@gnus.org>]
* bug#6959: [PATCH] Add Microsoft support to cc-mode [not found] ` <87r3g0t1jx.fsf@gnus.org> @ 2016-02-26 6:44 ` Daniel Colascione 0 siblings, 0 replies; 6+ messages in thread From: Daniel Colascione @ 2016-02-26 6:44 UTC (permalink / raw) To: Lars Ingebrigtsen, Daniel Colascione; +Cc: 6959, emacs-devel [-- Attachment #1: Type: text/plain, Size: 845 bytes --] On 02/25/2016 10:42 PM, Lars Ingebrigtsen wrote: > Daniel Colascione <dan.colascione@gmail.com> writes: > >> Microsoft uses a... unique programming style (erm, typedef void >> VOID?!) that tends to trip up cc-mode. Particularly problematic are >> certain code annotations, as described in >> http://msdn.microsoft.com/en-us/library/aa383701(VS.85).aspx. This >> patch adds support for this bizarre programming style and allows one >> to work on idiomatic Windows sources comfortably. >> >> You can get the diff at >> >> http://bazaar.launchpad.net/~dan-colascione/emacs/c++0x/revision/101039 > > Could you resend the patch (if this is still an issue)? It's not worth thinking about anymore. These days, I'd just define a derived mode and be done with it. Besides, as I recall, performance wasn't great with that patch. [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-02-26 6:44 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2010-08-31 21:01 [PATCH] Add Microsoft support to cc-mode Daniel Colascione 2010-09-01 6:38 ` bug#6959: " Stefan Monnier [not found] ` <jwvoccic73r.fsf-monnier+emacs@gnu.org> 2011-01-14 5:54 ` Daniel Colascione 2011-01-14 15:52 ` Stefan Monnier 2016-02-26 6:42 ` Lars Ingebrigtsen [not found] ` <87r3g0t1jx.fsf@gnus.org> 2016-02-26 6:44 ` Daniel Colascione
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).