From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: 7840@debbugs.gnu.org
Subject: bug#7840: SYMBOL_VALUE in terminal.c (was 23.2.91; default-terminal-coding-system not inherited by created terminals)
Date: Mon, 14 Feb 2011 13:05:44 -0500 [thread overview]
Message-ID: <jwvbp2emr0w.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87wrl423dm.fsf@stupidchicken.com> (Chong Yidong's message of "Sat, 12 Feb 2011 19:18:45 -0500")
>> * terminal.c (create_terminal): Use default-keyboard-coding-system
>> and default-terminal-coding-system to initialize coding systems of
>> the new terminal. (Bug#7840)
>>
>> ! keyboard_coding = SYMBOL_VALUE (intern ("default-keyboard-coding-system"));
>> ! if (NILP (keyboard_coding)
>> ! || EQ (keyboard_coding, Qunbound)
>> ! || NILP (Fcoding_system_p (keyboard_coding)))
>> ! keyboard_coding = Qno_conversion;
>> ! terminal_coding = SYMBOL_VALUE (intern ("default-terminal-coding-system"));
> This change doesn't build on the trunk, due to Stefan's 2010-04-20
> change removing SYMBOL_VALUE.
> I left out this change when doing the last merge from the branch. Would
> you mind working up a separate patch and applying it to the trunk?
> (Fsymbol_value apparently doesn't work here, because the symbols can be
> unbound and we don't want to signal an error.)
We can just use Fboundp tests, when needed.
Stefan
next prev parent reply other threads:[~2011-02-14 18:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-14 3:45 bug#7840: 23.2.91; default-terminal-coding-system not inherited by created terminals Eli Zaretskii
2011-01-14 15:33 ` Stefan Monnier
2011-02-12 9:55 ` Eli Zaretskii
2011-02-13 0:18 ` bug#7840: SYMBOL_VALUE in terminal.c (was 23.2.91; default-terminal-coding-system not inherited by created terminals) Chong Yidong
2011-02-14 18:05 ` Stefan Monnier [this message]
2011-02-18 14:51 ` Eli Zaretskii
2011-02-18 17:33 ` Stefan Monnier
2011-02-18 17:46 ` Eli Zaretskii
2011-02-18 21:35 ` Stefan Monnier
2011-02-19 8:05 ` bug#7840: SYMBOL_VALUE in terminal.c Eli Zaretskii
2011-02-19 21:14 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvbp2emr0w.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=7840@debbugs.gnu.org \
--cc=cyd@stupidchicken.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).