From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#8951: 24.0.50; [PATCH] enhancement request: buttonize key names Date: Mon, 04 Jul 2011 16:28:33 -0400 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1309811679 13237 80.91.229.12 (4 Jul 2011 20:34:39 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 4 Jul 2011 20:34:39 +0000 (UTC) Cc: 8951@debbugs.gnu.org To: "Drew Adams" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 04 22:34:34 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Qdpqg-0001x1-Kc for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Jul 2011 22:34:30 +0200 Original-Received: from localhost ([::1]:44951 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qdpqf-0005I4-F6 for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Jul 2011 16:34:29 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:37084) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QdplQ-0004OP-F9 for bug-gnu-emacs@gnu.org; Mon, 04 Jul 2011 16:29:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QdplP-00073a-3h for bug-gnu-emacs@gnu.org; Mon, 04 Jul 2011 16:29:04 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:39731) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QdplO-00073U-Li for bug-gnu-emacs@gnu.org; Mon, 04 Jul 2011 16:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QdplO-0006ti-2B; Mon, 04 Jul 2011 16:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Jul 2011 20:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8951 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 8951-submit@debbugs.gnu.org id=B8951.130981132626491 (code B ref 8951); Mon, 04 Jul 2011 20:29:02 +0000 Original-Received: (at 8951) by debbugs.gnu.org; 4 Jul 2011 20:28:46 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qdpl7-0006tE-Rc for submit@debbugs.gnu.org; Mon, 04 Jul 2011 16:28:46 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qdpl5-0006t2-Gn for 8951@debbugs.gnu.org; Mon, 04 Jul 2011 16:28:44 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EACwiEk5FxIxr/2dsb2JhbABTp3t4iHrBMoY2BJ5chCw X-IronPort-AV: E=Sophos;i="4.65,475,1304308800"; d="scan'208";a="120416841" Original-Received: from 69-196-140-107.dsl.teksavvy.com (HELO pastel.home) ([69.196.140.107]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 04 Jul 2011 16:28:36 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 649E158DBA; Mon, 4 Jul 2011 16:28:33 -0400 (EDT) In-Reply-To: (Drew Adams's message of "Tue, 28 Jun 2011 09:38:03 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 04 Jul 2011 16:29:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:47991 Archived-At: > What is the feature? Let users click a key description (i.e., a > key name, such as `C-f') in a buffer such as *Help* to see the > associated help. This applies to key descriptions derived from > \[...] doc patterns (only). That looks like a good idea. Have you tried to plug it directly into substitute-command-keys instead? Are there places where such buttons become annoying? Basically, the thing I don't like about your patch is the resulting redundancy between help-substitute-command-keys and substitute-command-keys, which could be removed by getting rid of the C version and only using the new Elisp version. Stefan