From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#12647: 24.2.50; emacs --daemon broken in tty Date: Tue, 16 Oct 2012 09:20:06 -0400 Message-ID: References: <20121014154458.GA14676@c3po> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1350393662 16658 80.91.229.3 (16 Oct 2012 13:21:02 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 16 Oct 2012 13:21:02 +0000 (UTC) Cc: 12647@debbugs.gnu.org, Toby Cubitt To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 16 15:21:09 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TO752-0000u2-Je for geb-bug-gnu-emacs@m.gmane.org; Tue, 16 Oct 2012 15:21:08 +0200 Original-Received: from localhost ([::1]:52911 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TO74v-0005Mo-Bv for geb-bug-gnu-emacs@m.gmane.org; Tue, 16 Oct 2012 09:21:01 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:33566) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TO74n-0005Mc-Vz for bug-gnu-emacs@gnu.org; Tue, 16 Oct 2012 09:20:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TO74j-0002JJ-SP for bug-gnu-emacs@gnu.org; Tue, 16 Oct 2012 09:20:53 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:36081) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TO74j-0002J9-NW for bug-gnu-emacs@gnu.org; Tue, 16 Oct 2012 09:20:49 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TO75t-0000wa-UD for bug-gnu-emacs@gnu.org; Tue, 16 Oct 2012 09:22:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 Oct 2012 13:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12647 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 12647-submit@debbugs.gnu.org id=B12647.13503936903585 (code B ref 12647); Tue, 16 Oct 2012 13:22:01 +0000 Original-Received: (at 12647) by debbugs.gnu.org; 16 Oct 2012 13:21:30 +0000 Original-Received: from localhost ([127.0.0.1]:46332 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TO75N-0000vm-Rm for submit@debbugs.gnu.org; Tue, 16 Oct 2012 09:21:30 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:65332) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TO75J-0000vX-Ns for 12647@debbugs.gnu.org; Tue, 16 Oct 2012 09:21:28 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ai0FAG6Zu09MCoeh/2dsb2JhbABEsEiDSYEIghUBAQQBViMFCwsOJhIUGA0kiBwFugmQRAOjM4FYgwU X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="201773573" Original-Received: from 76-10-135-161.dsl.teksavvy.com (HELO pastel.home) ([76.10.135.161]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 16 Oct 2012 09:20:07 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id AA5AC59520; Tue, 16 Oct 2012 09:20:06 -0400 (EDT) In-Reply-To: (Glenn Morris's message of "Tue, 16 Oct 2012 03:00:21 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:65659 Archived-At: > This is due to the various changes related to display handling in > r110444 (cygw32). The specific error is from x-initialize-window-system, > which cannot find a display (don't ask me why getenv DISPLAY doesn't > work here). He said he started "emacs --daemon" outside of X windows, so DISPLAY is not set. > In the past, frame.el set x-display-name, but it does not do > that any more. Where did it do it? > The following example frame.el change makes it work again, but someone > should check this area. To a large extent x-display-name should disappear, replaced by explicit parameters, since it doesn't make much sense in a multi-display context. So this part of the code is pretty ugly. Your patch is probably OK in the sense that it doesn't seem to make things significantly worse. Stefan