From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#11520: 24.1.50; delete-selection-mode conflicts with electric-pair-mode Date: Tue, 23 Oct 2012 11:10:39 -0400 Message-ID: References: <87ipdqx6e4.fsf@gnu.org> <87a9z19jgj.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1351005087 13863 80.91.229.3 (23 Oct 2012 15:11:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 23 Oct 2012 15:11:27 +0000 (UTC) Cc: Chong Yidong , 11520-done@debbugs.gnu.org To: Simon Law Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 23 17:11:33 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TQg8j-0005CG-5X for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Oct 2012 17:11:33 +0200 Original-Received: from localhost ([::1]:46542 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQg8b-0008Bl-71 for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Oct 2012 11:11:25 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:40428) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQg8T-0008Ah-Ii for bug-gnu-emacs@gnu.org; Tue, 23 Oct 2012 11:11:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQg8L-0004oR-Gp for bug-gnu-emacs@gnu.org; Tue, 23 Oct 2012 11:11:17 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:47642) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQg8L-0004oI-Dg for bug-gnu-emacs@gnu.org; Tue, 23 Oct 2012 11:11:09 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TQgA9-0002Yp-Sa for bug-gnu-emacs@gnu.org; Tue, 23 Oct 2012 11:13:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Oct 2012 15:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11520 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11520-done@debbugs.gnu.org id=D11520.13510051619810 (code D ref 11520); Tue, 23 Oct 2012 15:13:01 +0000 Original-Received: (at 11520-done) by debbugs.gnu.org; 23 Oct 2012 15:12:41 +0000 Original-Received: from localhost ([127.0.0.1]:57892 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TQg9o-0002YA-Qi for submit@debbugs.gnu.org; Tue, 23 Oct 2012 11:12:41 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:9373) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TQg9n-0002Xj-FB for 11520-done@debbugs.gnu.org; Tue, 23 Oct 2012 11:12:39 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAG6Zu09MCqNj/2dsb2JhbABEtBGBCIIVAQEEAVYjBQsLDiYSFBgNJByIAAULuX6QRAOjM4FYgwU X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="202542908" Original-Received: from 76-10-163-99.dsl.teksavvy.com (HELO pastel.home) ([76.10.163.99]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 23 Oct 2012 11:10:40 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 6B2C959347; Tue, 23 Oct 2012 11:10:39 -0400 (EDT) In-Reply-To: (Simon Law's message of "Mon, 22 Oct 2012 21:07:15 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:65916 Archived-At: > Yeah, I wasn't sure about delete-selection-pre-hook, but that's what > the function was already called, so I wasn't going to change the API > there. Yes, the function name is better left as is (and really isn't bad), the error was in the docstring (where you described the function as a normal hook). >> And the symbol symbol is named with "-hook" (rather than with >> "-hooks") for normal hooks and "-functions" for abnormal hooks. > Ah, I read that it was either one or the other in > http://www.gnu.org/software/emacs/manual/html_node/elisp/Hooks.html. Historically, "-hooks" was used, but they've (all?) been renamed to "-hook". > Perhaps that documentation should discourage the -hooks convention? Yes, thanks, the wording wasn't clear enough. Fixed. >> - there's no self-insert-iso in Emacs, so I'd rather not touch it. > delete-selection-mode.el used to touch self-insert-iso, as does > cua-rect.el. Is this something to clean up, or is there something I'm > missing? I don't know where this self-insert-iso comes from, so we should just remove it, but I'll keep this change for after the feature freeze. For now, I simply left the setting as it used to be. > Finally, I noticed that you created self-insert-uses-region-functions, > but there is no defvar or docstring for that. For future reference, is > it normal that packages have hidden hooks like that? No, it's not normal. Thanks for catching this missing commit. Stefan