From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#15767: 24.3; [patch] electric-indent-mode bug Date: Mon, 04 Nov 2013 15:04:31 -0500 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1383595520 11870 80.91.229.3 (4 Nov 2013 20:05:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 4 Nov 2013 20:05:20 +0000 (UTC) Cc: 15767-done@debbugs.gnu.org To: Dave Abrahams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 04 21:05:24 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VdQOn-0001jB-Qk for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Nov 2013 21:05:21 +0100 Original-Received: from localhost ([::1]:51808 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdQOn-0001J6-AZ for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Nov 2013 15:05:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46500) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdQOc-0001E2-UQ for bug-gnu-emacs@gnu.org; Mon, 04 Nov 2013 15:05:18 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VdQOV-0000dH-LD for bug-gnu-emacs@gnu.org; Mon, 04 Nov 2013 15:05:10 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:48835) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdQOV-0000cz-Iv for bug-gnu-emacs@gnu.org; Mon, 04 Nov 2013 15:05:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VdQOU-0004f6-Nd for bug-gnu-emacs@gnu.org; Mon, 04 Nov 2013 15:05:02 -0500 Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Nov 2013 20:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 15767 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 15767@debbugs.gnu.org, monnier@iro.umontreal.ca, dave@boostpro.com Original-Received: via spool by 15767-done@debbugs.gnu.org id=D15767.138359548417885 (code D ref 15767); Mon, 04 Nov 2013 20:05:01 +0000 Original-Received: (at 15767-done) by debbugs.gnu.org; 4 Nov 2013 20:04:44 +0000 Original-Received: from localhost ([127.0.0.1]:34619 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VdQOB-0004eO-PG for submit@debbugs.gnu.org; Mon, 04 Nov 2013 15:04:44 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:7157) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VdQO9-0004eA-Vj for 15767-done@debbugs.gnu.org; Mon, 04 Nov 2013 15:04:42 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFFxLzd/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgbBLZEKA4hhnBmBXoMV X-IPAS-Result: Av8EABK/CFFFxLzd/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgbBLZEKA4hhnBmBXoMV X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="37072884" Original-Received: from 69-196-188-221.dsl.teksavvy.com (HELO pastel.home) ([69.196.188.221]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 04 Nov 2013 15:04:35 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 0BCEA60D75; Mon, 4 Nov 2013 15:04:32 -0500 (EST) In-Reply-To: (Dave Abrahams's message of "Wed, 30 Oct 2013 16:03:34 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:79996 Archived-At: > (electric-indent-mode) > (electric-layout-mode) > (setq electric-indent-chars (append "{}" electric-indent-chars)) > (setq electric-layout-rules '((?\{ . after) (?\} . before))) > 3. type `f o o SPC {' Thanks. Your patch defeated a useful case, so I replaced it with the one below, Stefan --- lisp/electric.el 2013-10-07 18:51:26 +0000 +++ lisp/electric.el 2013-11-04 20:01:20 +0000 @@ -251,9 +251,10 @@ ;; whereas we need `move after insertion', so we do the ;; save/restore by hand. (goto-char before) + (when (eolp) ;; Remove the trailing whitespace after indentation because ;; indentation may (re)introduce the whitespace. - (delete-horizontal-space t)))) + (delete-horizontal-space t))))) (unless (or (memq indent-line-function '(indent-to-left-margin)) (and electric-indent-inhibit (> pos (line-beginning-position))))