From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#19338: [PATCH 1/3] eldoc: use default eldoc function if local one gives no results Date: Wed, 10 Dec 2014 21:38:44 -0500 Message-ID: References: <1418232280-16915-1-git-send-email-mpn@google.com> <1418233785-18020-1-git-send-email-mpn@google.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1418265571 22827 80.91.229.3 (11 Dec 2014 02:39:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 11 Dec 2014 02:39:31 +0000 (UTC) Cc: 19338@debbugs.gnu.org To: Michal Nazarewicz Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 11 03:39:24 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Xytf2-0005zA-5b for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Dec 2014 03:39:24 +0100 Original-Received: from localhost ([::1]:48843 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xytf1-0005u0-QN for geb-bug-gnu-emacs@m.gmane.org; Wed, 10 Dec 2014 21:39:23 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53782) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xyter-0005ts-Ft for bug-gnu-emacs@gnu.org; Wed, 10 Dec 2014 21:39:20 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xyteg-0005XK-At for bug-gnu-emacs@gnu.org; Wed, 10 Dec 2014 21:39:13 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:32782) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xyteg-0005XG-6k for bug-gnu-emacs@gnu.org; Wed, 10 Dec 2014 21:39:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Xytef-00019O-UB for bug-gnu-emacs@gnu.org; Wed, 10 Dec 2014 21:39:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Dec 2014 02:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19338 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 19338-submit@debbugs.gnu.org id=B19338.14182655294402 (code B ref 19338); Thu, 11 Dec 2014 02:39:01 +0000 Original-Received: (at 19338) by debbugs.gnu.org; 11 Dec 2014 02:38:49 +0000 Original-Received: from localhost ([127.0.0.1]:42148 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XyteS-00018v-L7 for submit@debbugs.gnu.org; Wed, 10 Dec 2014 21:38:48 -0500 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:36284) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XyteQ-00018n-Md for 19338@debbugs.gnu.org; Wed, 10 Dec 2014 21:38:47 -0500 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id sBB2ciP3024420; Wed, 10 Dec 2014 21:38:45 -0500 Original-Received: by ceviche.home (Postfix, from userid 20848) id 5E363660F3; Wed, 10 Dec 2014 21:38:44 -0500 (EST) In-Reply-To: (Michal Nazarewicz's message of "Wed, 10 Dec 2014 22:46:21 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5151=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5151> : inlines <1625> : streams <1354955> : uri <1838084> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:97182 Archived-At: > So the point here is that I don't want major-mode to be aware of what > I might have set the default value of `eldoc-documentation-function' to The major mode doesn't have to be aware of it. It should simply always delegate to the default function (i.e. ideally use :before-until, of course that requires fixing the default value of eldoc-documentation-function). > (and work even if I change it at any point). Just like the `local' arg of add-hook, add-function correctly handles later changes to the global value of the variable. Stefan