From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#20260: 24.4.1; Triple-clicking selects and deselects the line in weird situations Date: Tue, 07 Apr 2015 14:53:42 -0400 Message-ID: References: <87iodb4jem.fsf@loki.jorgenschaefer.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1428432937 22208 80.91.229.3 (7 Apr 2015 18:55:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 7 Apr 2015 18:55:37 +0000 (UTC) Cc: 20260@debbugs.gnu.org To: Jorgen Schaefer Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 07 20:55:25 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YfYei-0005Kj-PX for geb-bug-gnu-emacs@m.gmane.org; Tue, 07 Apr 2015 20:55:24 +0200 Original-Received: from localhost ([::1]:47972 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YfYeh-0003P6-Rp for geb-bug-gnu-emacs@m.gmane.org; Tue, 07 Apr 2015 14:55:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43175) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YfYeQ-00034g-5Z for bug-gnu-emacs@gnu.org; Tue, 07 Apr 2015 14:55:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YfYeM-0007cT-S6 for bug-gnu-emacs@gnu.org; Tue, 07 Apr 2015 14:55:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58411) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YfYeM-0007bh-Pg for bug-gnu-emacs@gnu.org; Tue, 07 Apr 2015 14:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YfYeM-0001av-1a for bug-gnu-emacs@gnu.org; Tue, 07 Apr 2015 14:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Apr 2015 18:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20260 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20260-submit@debbugs.gnu.org id=B20260.14284328516070 (code B ref 20260); Tue, 07 Apr 2015 18:55:01 +0000 Original-Received: (at 20260) by debbugs.gnu.org; 7 Apr 2015 18:54:11 +0000 Original-Received: from localhost ([127.0.0.1]:48187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YfYdX-0001Zq-37 for submit@debbugs.gnu.org; Tue, 07 Apr 2015 14:54:11 -0400 Original-Received: from mercure.iro.umontreal.ca ([132.204.24.67]:46219) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YfYdV-0001Zi-C0 for 20260@debbugs.gnu.org; Tue, 07 Apr 2015 14:54:09 -0400 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 15A079C157; Tue, 7 Apr 2015 14:54:06 -0400 (EDT) Original-Received: from lechon.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 0CC511E5B8B; Tue, 7 Apr 2015 14:53:43 -0400 (EDT) Original-Received: by lechon.iro.umontreal.ca (Postfix, from userid 20848) id E750CB4122; Tue, 7 Apr 2015 14:53:42 -0400 (EDT) In-Reply-To: <87iodb4jem.fsf@loki.jorgenschaefer.de> (Jorgen Schaefer's message of "Sun, 05 Apr 2015 00:29:21 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-1.49, requis 5, autolearn=not spam, ALL_TRUSTED -2.82, MC_CLICKON 0.22, MC_DESACTV 1.11, MC_TSTLAST 0.00) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:101267 Archived-At: > Triple-click on the "World" in the *Bug* buffer. Notice that Emacs > selects the whole line only momentarily, and then deselects it again > immediately. Indeed. I though I had fixed this in Emacs-25 by making deactivate-mark buffer-local, but I actually failed to adjust the C code accordingly. The patch below seems to fix your test case. Can you confirm it also fixes your real use case? Stefan diff --git a/src/fileio.c b/src/fileio.c index d4e12cb..a6e7fbb 100644 --- a/src/fileio.c +++ b/src/fileio.c @@ -4165,7 +4165,7 @@ by calling `format-decode', which see. */) Vdeactivate_mark = old_Vdeactivate_mark; } else - Vdeactivate_mark = Qt; + Fset (Qdeactivate_mark, Qt); emacs_close (fd); clear_unwind_protect (fd_index); diff --git a/src/insdel.c b/src/insdel.c index 80650be..22c2bcc 100644 --- a/src/insdel.c +++ b/src/insdel.c @@ -1846,7 +1846,7 @@ prepare_to_modify_buffer_1 (ptrdiff_t start, ptrdiff_t end, = call1 (Fsymbol_value (Qregion_extract_function), Qnil); signal_before_change (start, end, preserve_ptr); - Vdeactivate_mark = Qt; + Fset (Qdeactivate_mark, Qt); } /* Like above, but called when we know that the buffer text