From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: phillip.lord@russet.org.uk (Phillip Lord)
Cc: Alan Mackenzie <acm@muc.de>, 23785@debbugs.gnu.org
Subject: bug#23785: Emacs 25: "Undo" overdoes things.
Date: Sat, 18 Jun 2016 00:46:44 -0400 [thread overview]
Message-ID: <jwvbn2zcdw6.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <87ziqjwkrb.fsf@russet.org.uk> (Phillip Lord's message of "Fri, 17 Jun 2016 22:47:20 +0100")
> Stefan what do you think? You suggested something like this for
> Bug#22295 also. I think that the problem is the same; if I read
> insert-file-contents correctly, it disables collection of undo
> information. I may well be reading it wrong though.
Looks OK to me, yes.
> Given that this has turned up in two places now, it may be a wider
> problem, and the more general solution might be the better one. It
> might also invalidate the necessity for 12e009e52, but I haven't
> tested that yet.
It probably makes 12e009e52 unnecessary, indeed, but I'd argue that
it is wrong of viper-adjust-undo to remove the topmost undo-boundary, so
IMO we should keep 12e009e52 (if not in emacs-25 at least in master).
Similarly I think it's still a bug that revert-buffer removes
a pre-existing undo-boundary (even if that bug ends up hidden by adding
current-buffer unconditionally in undo-auto--boundaries).
Stefan
next prev parent reply other threads:[~2016-06-18 4:46 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 15:02 bug#23785: Emacs 25: "Undo" overdoes things Alan Mackenzie
2016-06-17 17:15 ` Eli Zaretskii
2016-06-17 17:45 ` Alan Mackenzie
2016-06-17 20:07 ` Eli Zaretskii
2016-06-17 21:47 ` Phillip Lord
2016-06-18 4:46 ` Stefan Monnier [this message]
2016-06-18 7:54 ` Eli Zaretskii
2016-06-18 18:42 ` Stefan Monnier
2016-06-18 19:02 ` Eli Zaretskii
2016-06-18 19:52 ` Stefan Monnier
2016-06-19 22:45 ` bug#23785: Emacs 25: 'Undo' " Phillip Lord
2016-06-20 0:59 ` Stefan Monnier
2016-06-20 12:47 ` Phillip Lord
2016-06-20 14:04 ` Stefan Monnier
2016-06-20 15:03 ` Phillip Lord
2016-06-20 15:34 ` Eli Zaretskii
2016-06-20 17:12 ` Phillip Lord
2016-06-21 13:17 ` Eli Zaretskii
2016-06-21 14:30 ` Phillip Lord
2016-06-21 21:25 ` Stefan Monnier
2016-06-21 22:08 ` Phillip Lord
2020-09-04 14:03 ` Lars Ingebrigtsen
2020-09-05 13:15 ` Alan Mackenzie
2016-06-21 13:18 ` Eli Zaretskii
2016-06-21 14:29 ` Phillip Lord
2016-06-21 16:13 ` Eli Zaretskii
2016-06-17 21:23 ` bug#23785: Emacs 25: "Undo" " Phillip Lord
2016-06-18 17:41 ` Alan Mackenzie
2016-06-17 21:49 ` Óscar Fuentes
2016-06-20 12:33 ` Phillip Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvbn2zcdw6.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=23785@debbugs.gnu.org \
--cc=acm@muc.de \
--cc=phillip.lord@russet.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).