From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#25929: 25.2; map-delete doesn't delete permanently 1st alist elt Date: Thu, 02 Mar 2017 10:12:09 -0500 Message-ID: References: <87k288p2oq.fsf@gmail.com> <87k288kkqr.fsf@petton.fr> <87efyfluvi.fsf@petton.fr> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1488467593 22200 195.159.176.226 (2 Mar 2017 15:13:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 2 Mar 2017 15:13:13 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: 25929@debbugs.gnu.org, Tino Calancha To: Nicolas Petton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 02 16:13:09 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cjSPi-0005Go-4i for geb-bug-gnu-emacs@m.gmane.org; Thu, 02 Mar 2017 16:13:06 +0100 Original-Received: from localhost ([::1]:52877 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cjSPo-0004Qz-7N for geb-bug-gnu-emacs@m.gmane.org; Thu, 02 Mar 2017 10:13:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53555) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cjSPi-0004Qk-DA for bug-gnu-emacs@gnu.org; Thu, 02 Mar 2017 10:13:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cjSPe-0000Aq-F1 for bug-gnu-emacs@gnu.org; Thu, 02 Mar 2017 10:13:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38505) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cjSPe-0000AX-Br for bug-gnu-emacs@gnu.org; Thu, 02 Mar 2017 10:13:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cjSPe-0006Se-3p for bug-gnu-emacs@gnu.org; Thu, 02 Mar 2017 10:13:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Mar 2017 15:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25929 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25929-submit@debbugs.gnu.org id=B25929.148846753924790 (code B ref 25929); Thu, 02 Mar 2017 15:13:02 +0000 Original-Received: (at 25929) by debbugs.gnu.org; 2 Mar 2017 15:12:19 +0000 Original-Received: from localhost ([127.0.0.1]:36704 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cjSOx-0006Rl-6q for submit@debbugs.gnu.org; Thu, 02 Mar 2017 10:12:19 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:47481) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cjSOu-0006RW-PV for 25929@debbugs.gnu.org; Thu, 02 Mar 2017 10:12:18 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0AsBAAtNbhY/zPujBheGwEBAQMBAQEJAQEBg1CEeYVWhQJzkR0BlQuCDRqGAgQCAoJHQBgBAgEBAQEBAQFiKIRxBlYjEAs0EhQYDSSKDbQCixUBAQEHAgElizuKOQWQVItVlBWIXIZgkzcfOIEBIRQILD6ETh6BfyKKMwEBAQ X-IPAS-Result: A0AsBAAtNbhY/zPujBheGwEBAQMBAQEJAQEBg1CEeYVWhQJzkR0BlQuCDRqGAgQCAoJHQBgBAgEBAQEBAQFiKIRxBlYjEAs0EhQYDSSKDbQCixUBAQEHAgElizuKOQWQVItVlBWIXIZgkzcfOIEBIRQILD6ETh6BfyKKMwEBAQ X-IronPort-AV: E=Sophos;i="5.35,231,1484024400"; d="scan'208";a="294273723" Original-Received: from 24-140-238-51.cpe.teksavvy.com (HELO pastel.home) ([24.140.238.51]) by smtp.teksavvy.com with ESMTP; 02 Mar 2017 10:12:10 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id E687F654DD; Thu, 2 Mar 2017 10:12:09 -0500 (EST) In-Reply-To: <87efyfluvi.fsf@petton.fr> (Nicolas Petton's message of "Thu, 02 Mar 2017 13:34:57 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:130056 Archived-At: > (macroexp-let2 nil key > `(progn > (map--dispatch ,map > :list (setf (alist-get ,key ,map nil t) nil) > :hash-table (remhash ,key ,map) > :array (and (>= ,key 0) > (<= ,key (seq-length ,map)) > (aset ,map ,key nil))) > ,map))) Note that this will make it pretty much impossible to use cl-generic dispatch. A better option might be to provide a map-remove which works functionally (i.e. doesn't modify its argument by side-effects), and then change map-delete to signal an error when we ask to delete the first element of the list (and to stop returning the "new map" since it just works imperatively instead). Stefan