From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#30171: 27.0.50; {add-to,remove-from}-invisibility-spec don't treat t specially Date: Wed, 18 Apr 2018 08:35:53 -0400 Message-ID: References: <87d0yxh8ji.fsf@mouse.gnus.org> <831sfd2g9w.fsf@gnu.org> <87vacod9yl.fsf@mouse.gnus.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1524055036 6184 195.159.176.226 (18 Apr 2018 12:37:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 18 Apr 2018 12:37:16 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: p.stephani2@gmail.com, 30171@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Apr 18 14:37:12 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8mKl-0001VC-MD for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 Apr 2018 14:37:11 +0200 Original-Received: from localhost ([::1]:54337 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f8mMs-0006Vw-Bz for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 Apr 2018 08:39:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47291) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f8mJj-0003vi-KC for bug-gnu-emacs@gnu.org; Wed, 18 Apr 2018 08:36:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f8mJe-00060T-O0 for bug-gnu-emacs@gnu.org; Wed, 18 Apr 2018 08:36:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50674) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f8mJe-00060J-Jh for bug-gnu-emacs@gnu.org; Wed, 18 Apr 2018 08:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f8mJe-0002oY-DU for bug-gnu-emacs@gnu.org; Wed, 18 Apr 2018 08:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Apr 2018 12:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30171 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 30171-submit@debbugs.gnu.org id=B30171.152405495910808 (code B ref 30171); Wed, 18 Apr 2018 12:36:02 +0000 Original-Received: (at 30171) by debbugs.gnu.org; 18 Apr 2018 12:35:59 +0000 Original-Received: from localhost ([127.0.0.1]:58571 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8mJa-0002oG-Qg for submit@debbugs.gnu.org; Wed, 18 Apr 2018 08:35:58 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:45414) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8mJZ-0002o8-8Z for 30171@debbugs.gnu.org; Wed, 18 Apr 2018 08:35:57 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w3ICZwhU001473; Wed, 18 Apr 2018 08:35:59 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id A2D2F6A0EB; Wed, 18 Apr 2018 08:35:53 -0400 (EDT) In-Reply-To: <87vacod9yl.fsf@mouse.gnus.org> (Lars Ingebrigtsen's message of "Wed, 18 Apr 2018 13:34:42 +0200") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6267=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6267> : inlines <6570> : streams <1784382> : uri <2627551> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:145571 Archived-At: > The change below is the cause of this odd feature set, and I wonder > whether Stefan (who made the change) meant for it to do what it does. The commit message refers to bug#20468 where the discussion indicates that it seems to be on purpose. One way to look at it is that the patch made (remove-from-invisibility-spec FOO) give the same result as (add-to-invisibility-spec FOO) (remove-from-invisibility-spec FOO) I guess the fundamental problem here is that the special behavior for the value `t` of buffer-invisibility-spec is just not reflected in (add-to|remove-from)-invisibility-spec. So if you rely on the current value being `t` and someone comes along and just does (add-to-invisibility-spec (make-symbol "unused")), suddenly your invisible stuff becomes visible. IOW you just can't rely on the special `t` behavior: if you want your thing to be invisible, you need to either use the special `t` value of the `invisible` property (which is invisible regardless of buffer-invisibility-spec), or you need to add your value via add-to-invisibility-spec. Stefan