From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#34116: 27.0.50; minibuffer-force-complete-and-exit mostly broken Date: Thu, 17 Jan 2019 09:57:10 -0500 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1547737269 27711 195.159.176.226 (17 Jan 2019 15:01:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 17 Jan 2019 15:01:09 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 34116@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jan 17 16:01:05 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gk9AG-000771-RS for geb-bug-gnu-emacs@m.gmane.org; Thu, 17 Jan 2019 16:01:04 +0100 Original-Received: from localhost ([127.0.0.1]:46233 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gk9CN-0001bO-TP for geb-bug-gnu-emacs@m.gmane.org; Thu, 17 Jan 2019 10:03:15 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57383) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gk97M-0006Cz-NF for bug-gnu-emacs@gnu.org; Thu, 17 Jan 2019 09:58:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gk97K-0006ve-SN for bug-gnu-emacs@gnu.org; Thu, 17 Jan 2019 09:58:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35900) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gk97K-0006tA-Ac for bug-gnu-emacs@gnu.org; Thu, 17 Jan 2019 09:58:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gk97J-0004ze-Vr for bug-gnu-emacs@gnu.org; Thu, 17 Jan 2019 09:58:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Jan 2019 14:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34116 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 34116-submit@debbugs.gnu.org id=B34116.154773703619138 (code B ref 34116); Thu, 17 Jan 2019 14:58:01 +0000 Original-Received: (at 34116) by debbugs.gnu.org; 17 Jan 2019 14:57:16 +0000 Original-Received: from localhost ([127.0.0.1]:35181 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gk96Z-0004yc-It for submit@debbugs.gnu.org; Thu, 17 Jan 2019 09:57:15 -0500 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:57260) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gk96V-0004yQ-I5 for 34116@debbugs.gnu.org; Thu, 17 Jan 2019 09:57:13 -0500 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id x0HEvAqO032435; Thu, 17 Jan 2019 09:57:10 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 31BF86A58C; Thu, 17 Jan 2019 09:57:10 -0500 (EST) In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Thu, 17 Jan 2019 13:56:39 +0000") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6463=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6463> : inlines <6996> : streams <1810351> : uri <2781364> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:154515 Archived-At: > @@ -1257,29 +1257,32 @@ completion-all-sorted-completions > (defun minibuffer-force-complete-and-exit () > "Complete the minibuffer with first of the matches and exit." > (interactive) > - (minibuffer-force-complete) > + (minibuffer-force-complete nil nil t) > (completion--complete-and-exit > (minibuffer-prompt-end) (point-max) #'exit-minibuffer > ;; If the previous completion completed to an element which fails > ;; test-completion, then we shouldn't exit, but that should be rare. > (lambda () (minibuffer-message "Incomplete")))) Wouldn't it be simpler to change minibuffer-force-complete-and-exit so it checks test-completion before calling minibuffer-force-complete? Stefan