From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#38072: when `byte-compile-file' finds out that a file is `no-byte-compile', it ignores `load' parameter Date: Sat, 05 Sep 2020 11:26:16 -0400 Message-ID: References: <834kocrbg1.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27286"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Stefan Kangas , pogonyshev@gmail.com, 38072@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 05 17:27:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kEa5u-0006zm-E3 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Sep 2020 17:27:10 +0200 Original-Received: from localhost ([::1]:52138 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kEa5t-0002i9-Fz for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Sep 2020 11:27:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43756) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEa5m-0002gt-Sj for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2020 11:27:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60564) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kEa5m-0003ZO-Ja for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2020 11:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kEa5m-0004WP-Gc for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2020 11:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Sep 2020 15:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38072 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 38072-submit@debbugs.gnu.org id=B38072.159931958817318 (code B ref 38072); Sat, 05 Sep 2020 15:27:02 +0000 Original-Received: (at 38072) by debbugs.gnu.org; 5 Sep 2020 15:26:28 +0000 Original-Received: from localhost ([127.0.0.1]:43867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEa5D-0004VF-Pq for submit@debbugs.gnu.org; Sat, 05 Sep 2020 11:26:28 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:29225) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEa5D-0004V1-0w for 38072@debbugs.gnu.org; Sat, 05 Sep 2020 11:26:27 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id A38FE440BCB; Sat, 5 Sep 2020 11:26:21 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id EFFE2440BC8; Sat, 5 Sep 2020 11:26:18 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1599319578; bh=bheZ8r5y62OqbQpoNF/9GUs2J8/xnVLo6LMVdude4Xw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=WFjaJNllcEntTmkkFaTZCFyST9qr+PGOgasNhR7mT5OSd2U2uMZdqo8Sl7ojDaIjF XspJ+edCRsM6sHGmUYquU+jMnvn9AckGqT7u82IJnQ2SiisukeMdoF/mILF0NN6EFC iixZGNXjhWDhD1wItu/F/fI7TeYZcEjQ1EP/nJ5V/nDrEouGKgA114XgguWgChG7pO +Pap90i4AQHI2OcXDtx5zwu8FLComEkjEo5FxQVXeyEgPCQS4IMxTxk+rOJ7mZcKtr WziJP/Prw98nRa65wl0XHuW6KegpAAuqJ+KJT4qOrx7c2BdqjI5j0Xa72csI1r5HPh hYz92STBnAsDQ== Original-Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id AA9951204F6; Sat, 5 Sep 2020 11:26:18 -0400 (EDT) In-Reply-To: <834kocrbg1.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 05 Sep 2020 09:21:02 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187263 Archived-At: >> Compile a file of Lisp code named FILENAME into a file of byte code. >> The output file=E2=80=99s name is generated by passing FILENAME to t= he >> function =E2=80=98byte-compile-dest-file=E2=80=99 (which see). >> With prefix arg (noninteractively: 2nd arg), LOAD the file after com= piling. >> ^^^^^^^^^= ^^^^^^ >>=20 >> So should we load the file if we did not compile the file? I'm thinking >> yes, and I don't see what it could hurt to change it to load the file. >> If the user uses a prefix arg or the LOAD argument from Lisp, surely >> that was the intention. >>=20 >> But on the other hand the text above seems deliberate, somehow? (And >> AFAICT the behavior has been not to load the file since pretty much >> forever, possibly since byte-compilation was first added.) > > I'm indeed bothered by backward incompatibility of such a change. > Paul expected the file to be loaded unconditionally, but how do we > know someone else isn't expecting the opposite in this case? Also, do > we want the same behavior in the interactive case? > > At the very least, if we decide to install this, the change in > behavior should be in NEWS. > > Stefan, any comments on this? FWIW, I find the "and load" feature to be a mistake: the function should return whether or not it successfully compiled the file, but shouldn't offer to load the result, since the callers can just as easily do it themselves (and then they can easily control what happens when compilation did not succeed). So, I'd suggest we deprecate that "feature" rather than try and decide which behavior is better. Stefan